Fix a bunch of issues blocking 64-bit orderfile generation.

tools/cygprofile/symbol_extractor.py

 #!/usr/bin/python
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Utilities to get and manipulate symbols from a binary."""
 
 import collections
 import os
 import re
 import subprocess
 import sys
 
 sys.path.insert(
     0, os.path.join(os.path.dirname(__file__), os.pardir, os.pardir,
                     'third_party', 'android_platform', 'development',
                     'scripts'))
 import symbol
 
-
-# TODO(lizeb): Change symbol.ARCH to the proper value when "arm" is no longer
-# the only possible value.
 _OBJDUMP_BINARY = symbol.ToolPath('objdump')
 
 
 SymbolInfo = collections.namedtuple('SymbolInfo', ('name', 'offset', 'size',
                                                    'section'))
 
+def SetArchitecture(arch):
+  """Set the architecture for binaries to be symbolized."""
+  symbol.ARCH = arch
+  global _OBJDUMP_BINARY

[pasko, 2015/02/04 19:08:26]

let's not increase global state. How about _GetObjdumpBinary()?

[azarchs, 2015/02/05 09:40:02]

This isn't increasing global state - just changing the content of a variable
that is already global.  Do we want to do make that variable not global?  It
sounds like a good idea, but would be a more extensive change as we'd need to
turn this whole file into a class instead of a bunch of global methods.

[pasko, 2015/02/05 10:24:50]

Let's eliminate the _OBJDUMP_BINARY (referenced only once in this file), and
always call symbol.ToolPath('objdump').

The SetArchitecture(arch) would stay and be a one liner to modify the
symbol.ARCH in an obvious way.

WDYT?

[azarchs, 2015/02/05 10:31:01]

Done.

+  _OBJDUMP_BINARY = symbol.ToolPath('objdump')
+
 
 def _FromObjdumpLine(line):
   """Create a SymbolInfo by parsing a properly formatted objdump output line.
 
   Args:
     line: line from objdump
 
   Returns:
     An instance of SymbolInfo if the line represents a symbol, None otherwise.
   """
@@ skipping 72 matching lines @@
 def CreateNameToSymbolInfo(symbol_infos):
   """Create a dict {name: symbol_info, ...}.
 
   Args:
     symbol_infos: iterable of SymbolInfo instances
 
   Returns:
     a dict {name: symbol_info, ...}
   """
   return {symbol_info.name: symbol_info for symbol_info in symbol_infos}