Refactor LengthMode handling in SVGLengthContext

Refactor LengthMode handling in SVGLengthContext

The switch that selects the correct "dimension" factor to scale with is
repeated three times. Refactor the code so that we get the factor from a
helper function instead.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189523

[fs, 2015-02-04 15:05:24]

fs@opera.com changed reviewers:
+ ed@opera.com, pdr@chromium.org

[fs, 2015-02-04 16:29:19]

Shaves a few bytes off of the involved methods as well a making for less lines
of code. PTAL.

[pdr., 2015-02-04 16:34:10]

Nice! LGTM

I tried to think of another name than "factorForLengthMode" because factor can
be both a noun and a verb, but I couldn't come up with anything.

[fs, 2015-02-04 16:53:32]

On 2015/02/04 16:34:10, pdr wrote:
> Nice! LGTM
> 
> I tried to think of another name than "factorForLengthMode" because factor can
> be both a noun and a verb, but I couldn't come up with anything.

dimensionForLengthMode (almost true), dimensionFactorForLengthMode (still has
factor, but maybe more clear it's a noun?)

[pdr., 2015-02-04 17:32:12]

On 2015/02/04 at 16:53:32, fs wrote:
> On 2015/02/04 16:34:10, pdr wrote:
> > Nice! LGTM
> > 
> > I tried to think of another name than "factorForLengthMode" because factor
can
> > be both a noun and a verb, but I couldn't come up with anything.
> 
> dimensionForLengthMode (almost true), dimensionFactorForLengthMode (still has
factor, but maybe more clear it's a noun?)

ooh, I like dimensionForLengthMode

[fs, 2015-02-04 18:03:50]

New patchsets have been uploaded after l-g-t-m from pdr@chromium.org

[fs, 2015-02-04 18:05:10]

On 2015/02/04 17:32:12, pdr wrote:
> On 2015/02/04 at 16:53:32, fs wrote:
> > On 2015/02/04 16:34:10, pdr wrote:
> > > Nice! LGTM
> > > 
> > > I tried to think of another name than "factorForLengthMode" because factor
> can
> > > be both a noun and a verb, but I couldn't come up with anything.
> > 
> > dimensionForLengthMode (almost true), dimensionFactorForLengthMode (still
has
> factor, but maybe more clear it's a noun?)
> 
> ooh, I like dimensionForLengthMode

dimensionForLengthMode it is.

[fs, 2015-02-04 18:05:15]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2015-02-04 18:06:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/902593002/20001

[commit-bot: I haz the power, 2015-02-04 19:26:16]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189523