Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 902583006: Add SkSVGCanvas (Closed)

Created:
5 years, 10 months ago by f(malita)
Modified:
5 years, 10 months ago
Reviewers:
hal.canary, mtklein, reed1
CC:
reviews_skia.org, shawcroft_google.com
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add SkSVGCanvas Add a public SVG canvas factory + move the SVG files from experimental -> src/svg/. Update current clients to the new API. R=reed@google.com, mtklein@google.com, halcanary@google.com Committed: https://skia.googlesource.com/skia/+/2aafe6f427f6d98aa4d173efc6195fe245add91d

Patch Set 1 #

Patch Set 2 : now with a source file doh #

Patch Set 3 : remove unused fwdecl #

Patch Set 4 : fix win warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -817 lines) Patch
M dm/DMSrcSink.cpp View 1 2 3 2 chunks +7 lines, -4 lines 0 comments Download
D experimental/svg/SkSVGDevice.h View 1 chunk +0 lines, -74 lines 0 comments Download
D experimental/svg/SkSVGDevice.cpp View 1 chunk +0 lines, -650 lines 0 comments Download
D experimental/svg/skp2svg.cpp View 1 chunk +0 lines, -70 lines 0 comments Download
M gyp/dm.gypi View 3 chunks +1 line, -2 lines 0 comments Download
M gyp/svg.gyp View 1 chunk +25 lines, -0 lines 0 comments Download
M gyp/tools.gyp View 2 chunks +3 lines, -3 lines 0 comments Download
A include/svg/SkSVGCanvas.h View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A src/svg/SkSVGCanvas.cpp View 1 1 chunk +17 lines, -0 lines 0 comments Download
A + src/svg/SkSVGDevice.h View 2 chunks +3 lines, -4 lines 0 comments Download
A + src/svg/SkSVGDevice.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
A + src/svg/skp2svg.cpp View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
f(malita)
5 years, 10 months ago (2015-02-06 17:58:09 UTC) #1
reed1
lgtm btw -- we seems to use Create and New about equally often in include/core... ...
5 years, 10 months ago (2015-02-06 18:37:13 UTC) #3
reed1
btw2 : we *may* want to separate out the svgparse into its own gyp at ...
5 years, 10 months ago (2015-02-06 18:38:11 UTC) #4
f(malita)
On 2015/02/06 18:37:13, reed1 wrote: > lgtm > > btw -- we seems to use ...
5 years, 10 months ago (2015-02-06 20:35:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902583006/40001
5 years, 10 months ago (2015-02-06 20:36:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/2337)
5 years, 10 months ago (2015-02-06 20:41:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902583006/60001
5 years, 10 months ago (2015-02-06 20:44:54 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 20:51:14 UTC) #13
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/2aafe6f427f6d98aa4d173efc6195fe245add91d

Powered by Google App Engine
This is Rietveld 408576698