Issue 902583005: Disable CaptivePortalBrowserTest.InterstitialTimerReloadWhileLoading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 902583005: Disable CaptivePortalBrowserTest.InterstitialTimerReloadWhileLoading (Closed)

Created:
5 years, 10 months ago by ccameron

Modified:
5 years, 10 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable CaptivePortalBrowserTest.InterstitialTimerReloadWhileLoading CaptivePortalBrowserTest.InterstitialTimerNavigateAwayWhileLoading was disabled a few days ago, this one has the same issue. BUG=453875 TBR=thestig@chromium.org NOTRY=true Committed: https://chromium.googlesource.com/chromium/src/+/ed26438c461023e27494f2040b52556b4385bf40

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	chrome/browser/captive_portal/captive_portal_browsertest.cc	View		1 chunk	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/ed26438c461023e27494f2040b52556b4385bf40 Cr-Commit-Position: refs/heads/master@{#314676}

5 years, 10 months ago (2015-02-04 23:34:08 UTC) #1

ccameron

Committed patchset #1 (id:1) manually as ed26438c461023e27494f2040b52556b4385bf40 (tree was closed).

5 years, 10 months ago (2015-02-04 23:34:22 UTC) #2

Lei Zhang

lgtm, though some people do not approve of using NOTRY=true. (See chromium-dev thread) There have ...

5 years, 10 months ago (2015-02-04 23:41:54 UTC) #3

ccameron

5 years, 10 months ago (2015-02-04 23:43:00 UTC) #4

Message was sent while issue was closed.

On 2015/02/04 23:41:54, Lei Zhang wrote:
> lgtm, though some people do not approve of using NOTRY=true. (See chromium-dev
> thread) There have been cases of people messing up the disabling of tests in
the
> past.

Okay, thanks for the heads-up. I'll avoid this for non-urgent change (& this one
wasn't urgent).

Expand Messages | Collapse Messages