Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 902583003: Update installer files now that PDF plugin is gone. (Closed)

Created:
5 years, 10 months ago by jam
Modified:
5 years, 10 months ago
Reviewers:
Michael Moss, kelvinp
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -40 lines) Patch
M chrome/chrome_installer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/common/installer.include View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/build/chromeos/FILES.cfg View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/tools/build/linux/FILES.cfg View 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
jam
5 years, 10 months ago (2015-02-04 18:04:54 UTC) #2
kelvinp
https://codereview.chromium.org/902583003/diff/1/chrome/chrome_installer.gypi File chrome/chrome_installer.gypi (left): https://codereview.chromium.org/902583003/diff/1/chrome/chrome_installer.gypi#oldcode464 chrome/chrome_installer.gypi:464: '<(PRODUCT_DIR)/libpdf.so', I did a string search in code search ...
5 years, 10 months ago (2015-02-04 18:09:35 UTC) #3
jam
https://codereview.chromium.org/902583003/diff/1/chrome/chrome_installer.gypi File chrome/chrome_installer.gypi (left): https://codereview.chromium.org/902583003/diff/1/chrome/chrome_installer.gypi#oldcode464 chrome/chrome_installer.gypi:464: '<(PRODUCT_DIR)/libpdf.so', On 2015/02/04 18:09:35, kelvinp wrote: > I did ...
5 years, 10 months ago (2015-02-04 18:10:13 UTC) #4
kelvinp
lgtm
5 years, 10 months ago (2015-02-04 18:13:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902583003/40001
5 years, 10 months ago (2015-02-04 18:15:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/40420)
5 years, 10 months ago (2015-02-04 18:23:10 UTC) #9
Michael Moss
lgtm
5 years, 10 months ago (2015-02-04 18:28:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902583003/40001
5 years, 10 months ago (2015-02-04 18:29:39 UTC) #13
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/a3873d3d9b508cb133fbd205f8f6433f13478805 Cr-Commit-Position: refs/heads/master@{#314599}
5 years, 10 months ago (2015-02-04 19:06:54 UTC) #14
jam
5 years, 10 months ago (2015-02-04 19:07:08 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
a3873d3d9b508cb133fbd205f8f6433f13478805 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698