Change error message for WebSocket tunnel failure.

Change error message for WebSocket tunnel failure.

Currently a proxy refusal to allow a WebSocket to establish a tunnel
results in an error message like:

WebSocket connection to 'ws://foo:5036/' failed: Error in connection
establishment: net::ERR_TUNNEL_CONNECTION_FAILED

It is not obvious from this message that a proxy is the cause of the
problem. Change the message to:

WebSocket connection to 'ws://foo:5036/' failed: Establishing a tunnel
via proxy server failed.

BUG=454311
TEST=net_unittests, browser_tests, layout tests

Committed: https://crrev.com/38fc268cf47aafb1c0bcc30611d68916caa3a6e4
Cr-Commit-Position: refs/heads/master@{#315257}

[Adam Rice, 2015-02-05 15:06:22]

ricea@chromium.org changed reviewers:
+ yhirano@chromium.org

[Adam Rice, 2015-02-05 15:06:22]

Sorry to add to your review burden, but since you are currently in the middle of
changing the websocket_test_util.* files and this CL will have to land after
yours, I think you are the most appropriate reviewer.

[yhirano, 2015-02-06 04:27:01]

https://codereview.chromium.org/902553002/diff/1/net/websockets/websocket_str...
File net/websockets/websocket_stream_test.cc (right):

https://codereview.chromium.org/902553002/diff/1/net/websockets/websocket_str...
net/websockets/websocket_stream_test.cc:1423: static const char
kTruncatedResponse[] =
Is this truncated?

https://codereview.chromium.org/902553002/diff/1/net/websockets/websocket_tes...
File net/websockets/websocket_test_util.h (right):

https://codereview.chromium.org/902553002/diff/1/net/websockets/websocket_tes...
net/websockets/websocket_test_util.h:29: class DeterministicSocketData;
+ class ProxyService;

[Adam Rice, 2015-02-06 08:05:57]

https://codereview.chromium.org/902553002/diff/1/net/websockets/websocket_str...
File net/websockets/websocket_stream_test.cc (right):

https://codereview.chromium.org/902553002/diff/1/net/websockets/websocket_str...
net/websockets/websocket_stream_test.cc:1423: static const char
kTruncatedResponse[] =
On 2015/02/06 04:27:01, yhirano wrote:
> Is this truncated?

No. Sorry. Too much copy and paste! Fixed.

[Adam Rice, 2015-02-06 08:06:14]

https://codereview.chromium.org/902553002/diff/1/net/websockets/websocket_tes...
File net/websockets/websocket_test_util.h (right):

https://codereview.chromium.org/902553002/diff/1/net/websockets/websocket_tes...
net/websockets/websocket_test_util.h:29: class DeterministicSocketData;
On 2015/02/06 04:27:01, yhirano wrote:
> + class ProxyService;

Done.

[yhirano, 2015-02-06 09:16:04]

lgtm

[Adam Rice, 2015-02-06 10:56:41]

New patchsets have been uploaded after l-g-t-m from yhirano@chromium.org

[Adam Rice, 2015-02-09 01:26:21]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2015-02-09 01:26:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/902553002/60001

[commit-bot: I haz the power, 2015-02-09 02:41:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-09 02:42:14]

Patchset 4 (id:??) landed as
https://crrev.com/38fc268cf47aafb1c0bcc30611d68916caa3a6e4
Cr-Commit-Position: refs/heads/master@{#315257}