Honor device type properties in gesture_property_provider

Honor device type properties in gesture_property_provider

The CL lets GesturePropertyProvider decide device types based
on a logic identical to the old inputcontrol script. This
solves some regressions we met on hybrid devices.

Contributed by sheckylin@chromium.org

BUG=454697
TEST=samus ChromeOS build

Committed: https://crrev.com/7b20d888f3b01b54f705bad7e320c8c759002c04
Cr-Commit-Position: refs/heads/master@{#314986}

[Shecky Lin, 2015-02-04 08:21:29]

sheckylin@chromium.org changed reviewers:
+ adlr@chromium.org, alexst@chromium.org, spang@chromium.org

[Shecky Lin, 2015-02-04 08:22:01]

spang: please take a look of this. Thank you!

[spang, 2015-02-04 17:47:10]

lgtm with nits

https://codereview.chromium.org/902543002/diff/1/ui/events/ozone/evdev/libges...
File ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc
(right):

https://codereview.chromium.org/902543002/diff/1/ui/events/ozone/evdev/libges...
ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc:435: const
GesturesProp* device_mouse,
device_mouse_property

https://codereview.chromium.org/902543002/diff/1/ui/events/ozone/evdev/libges...
ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc:436: const
GesturesProp* device_touchpad) {
device_touchpad_property

https://codereview.chromium.org/902543002/diff/1/ui/events/ozone/evdev/libges...
ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc:440:
is_mouse = device_mouse->GetBoolValue()[0];
else
  is_mouse = (evdev_class == EvdevClassMouse || evdev_class ==
EvdevClassMultitouchMouse);

https://codereview.chromium.org/902543002/diff/1/ui/events/ozone/evdev/libges...
ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc:442:
is_touchpad = device_touchpad->GetBoolValue()[0];
else
  is_touchpad = (evdev_class == EvdevClassTouchpad);

[Shecky Lin, 2015-02-06 04:50:12]

New patchsets have been uploaded after l-g-t-m from spang@chromium.org

[Shecky Lin, 2015-02-06 04:51:15]

Thanks!

https://codereview.chromium.org/902543002/diff/1/ui/events/ozone/evdev/libges...
File ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc
(right):

https://codereview.chromium.org/902543002/diff/1/ui/events/ozone/evdev/libges...
ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc:435: const
GesturesProp* device_mouse,
On 2015/02/04 17:47:10, spang wrote:
> device_mouse_property

Done.

https://codereview.chromium.org/902543002/diff/1/ui/events/ozone/evdev/libges...
ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc:436: const
GesturesProp* device_touchpad) {
On 2015/02/04 17:47:10, spang wrote:
> device_touchpad_property

Done.

https://codereview.chromium.org/902543002/diff/1/ui/events/ozone/evdev/libges...
ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc:440:
is_mouse = device_mouse->GetBoolValue()[0];
On 2015/02/04 17:47:10, spang wrote:
> else
>   is_mouse = (evdev_class == EvdevClassMouse || evdev_class ==
> EvdevClassMultitouchMouse);

Done.

https://codereview.chromium.org/902543002/diff/1/ui/events/ozone/evdev/libges...
ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc:442:
is_touchpad = device_touchpad->GetBoolValue()[0];
On 2015/02/04 17:47:10, spang wrote:
> else
>   is_touchpad = (evdev_class == EvdevClassTouchpad);

Done.

[Shecky Lin, 2015-02-06 06:08:55]

The CQ bit was checked by sheckylin@chromium.org

[commit-bot: I haz the power, 2015-02-06 06:09:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/902543002/20001

[commit-bot: I haz the power, 2015-02-06 06:32:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-06 06:33:35]

Patchset 2 (id:??) landed as
https://crrev.com/7b20d888f3b01b54f705bad7e320c8c759002c04
Cr-Commit-Position: refs/heads/master@{#314986}