Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 902533002: sandbox: run Credentials.CanDetectRoot as a SANDBOX_TEST (Closed)

Created:
5 years, 10 months ago by mdempsky
Modified:
5 years, 10 months ago
CC:
chromium-reviews, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sandbox: run Credentials.CanDetectRoot as a SANDBOX_TEST This test calls chdir() which corrupts subsequent tests like NamespaceSandboxTest. TBR=jln@chromium.org Committed: https://crrev.com/f90ebdf89f1fb8c2b8e5e54f5cbdb1846281d360 Cr-Commit-Position: refs/heads/master@{#314530}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M sandbox/linux/services/credentials_unittest.cc View 1 chunk +5 lines, -5 lines 1 comment Download

Messages

Total messages: 15 (5 generated)
mdempsky
5 years, 10 months ago (2015-02-04 08:05:42 UTC) #2
rickyz (no longer on Chrome)
lgtm Thanks for catching this
5 years, 10 months ago (2015-02-04 08:07:22 UTC) #3
mdempsky
On 2015/02/04 08:07:22, rickyz wrote: > lgtm > > Thanks for catching this Thanks for ...
5 years, 10 months ago (2015-02-04 08:09:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902533002/1
5 years, 10 months ago (2015-02-04 08:10:24 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-04 08:10:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902533002/1
5 years, 10 months ago (2015-02-04 09:27:28 UTC) #11
mdempsky
jln: TBR'ing you to appease commit-bot.
5 years, 10 months ago (2015-02-04 09:29:53 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 09:30:56 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f90ebdf89f1fb8c2b8e5e54f5cbdb1846281d360 Cr-Commit-Position: refs/heads/master@{#314530}
5 years, 10 months ago (2015-02-04 09:32:09 UTC) #14
jln (very slow on Chromium)
5 years, 10 months ago (2015-02-04 23:24:28 UTC) #15
Message was sent while issue was closed.
https://codereview.chromium.org/902533002/diff/1/sandbox/linux/services/crede...
File sandbox/linux/services/credentials_unittest.cc (right):

https://codereview.chromium.org/902533002/diff/1/sandbox/linux/services/crede...
sandbox/linux/services/credentials_unittest.cc:127: PCHECK(0 ==
chdir("/proc/"));
Note: we have SANDBOX_ASSERT_EQ() etc for these. (But this prints errno so,
good.)

Powered by Google App Engine
This is Rietveld 408576698