Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 902513003: win: various warnings in minidump_module_writer_test (Closed)

Created:
5 years, 10 months ago by scottmg
Modified:
5 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@minidump_test-2
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: various warnings in minidump_module_writer_test - time_t -> uint32_t warning - mixing bool and BOOLEAN - potentially unintialized variable warnings R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/75e6df238249568bf973987f9261e7a2e20d2ec9

Patch Set 1 #

Patch Set 2 : uninit locals #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M minidump/minidump_module_writer_test.cc View 1 8 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scottmg
5 years, 10 months ago (2015-02-05 03:51:06 UTC) #2
Mark Mentovai
LGTM
5 years, 10 months ago (2015-02-05 04:35:58 UTC) #3
scottmg
5 years, 10 months ago (2015-02-05 04:47:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
75e6df238249568bf973987f9261e7a2e20d2ec9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698