Fix flakiness of SelectFileDialogExtensionBrowserTest.SelectFileAndCancel.

Fix flakiness of SelectFileDialogExtensionBrowserTest.SelectFileAndCancel.

Previously the test waits for destruction of render view host to check if the
dialog has been closed or not. But test log shows there is a race and we cannot
ensure the extension dialog has been closed even if its render view host is
closed.

The CL let the test wait for SelectionFileDialog::Listener's call instead, where
we can ensure the dialog has been closed.

BUG=453613
TEST=SelectFileDialogExtensionBrowserTest.SelectFileAndCancel

Committed: https://crrev.com/33dcb1138514fadc1d4c9769ed5899eeca814231
Cr-Commit-Position: refs/heads/master@{#314510}

[hirono, 2015-02-04 05:17:50]

hirono@chromium.org changed reviewers:
+ thestig@chromium.org

[hirono, 2015-02-04 05:17:51]

PTAL, thanks!

[Lei Zhang, 2015-02-04 05:32:49]

LGTM

Thank you for the quick response.

https://codereview.chromium.org/902493002/diff/1/chrome/browser/ui/views/sele...
File chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc
(right):

https://codereview.chromium.org/902493002/diff/1/chrome/browser/ui/views/sele...
chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc:79: if
(message_loop_runner_)
Can you do "message_loop_runner_.get()" for http://crbug.com/110610 ?

[hirono, 2015-02-04 05:43:06]

New patchsets have been uploaded after l-g-t-m from thestig@chromium.org

[hirono, 2015-02-04 05:43:25]

Thank you!

https://codereview.chromium.org/902493002/diff/1/chrome/browser/ui/views/sele...
File chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc
(right):

https://codereview.chromium.org/902493002/diff/1/chrome/browser/ui/views/sele...
chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc:79: if
(message_loop_runner_)
On 2015/02/04 05:32:49, Lei Zhang wrote:
> Can you do "message_loop_runner_.get()" for http://crbug.com/110610 ?

Done.

[hirono, 2015-02-04 05:43:28]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2015-02-04 05:44:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/902493002/20001

[commit-bot: I haz the power, 2015-02-04 06:20:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-04 06:21:36]

Patchset 2 (id:??) landed as
https://crrev.com/33dcb1138514fadc1d4c9769ed5899eeca814231
Cr-Commit-Position: refs/heads/master@{#314510}