Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 902443003: Include safe_conversions.h in pdfium_engine.cc (Closed)

Created:
5 years, 10 months ago by Tom Sepez
Modified:
5 years, 10 months ago
Reviewers:
raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include safe_conversions.h in pdfium_engine.cc This is required for IWYU for checked_cast<>() use in this file; this happened to work because pdfium was leaking some base:: symbols. Fixing that issue in pdfium unmasked the problem. Committed: https://crrev.com/c85b8aba626c826fb6860e95b111d7247d987cc0 Cr-Commit-Position: refs/heads/master@{#314461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tom Sepez
Hey Raymes, please review. Looks like I missed this when landing your change a few ...
5 years, 10 months ago (2015-02-04 00:07:35 UTC) #2
raymes
lgtm
5 years, 10 months ago (2015-02-04 00:12:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902443003/1
5 years, 10 months ago (2015-02-04 00:23:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 01:24:15 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 01:25:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c85b8aba626c826fb6860e95b111d7247d987cc0
Cr-Commit-Position: refs/heads/master@{#314461}

Powered by Google App Engine
This is Rietveld 408576698