Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 902443002: Add unit tests for the 'disable-sync' flag (Closed)

Created:
5 years, 10 months ago by Daniel Imms
Modified:
5 years, 10 months ago
Reviewers:
stanisc, Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add unit tests for the 'disable-sync' flag BUG=454940 Committed: https://crrev.com/2828c829d001e239e66ba0f7313d37d0cb6e3352 Cr-Commit-Position: refs/heads/master@{#314673}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
A chrome/browser/sync/profile_sync_service_factory_unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Daniel Imms
5 years, 10 months ago (2015-02-03 21:09:29 UTC) #2
Daniel Imms
5 years, 10 months ago (2015-02-04 14:47:47 UTC) #4
stanisc
lgtm
5 years, 10 months ago (2015-02-04 21:11:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902443002/1
5 years, 10 months ago (2015-02-04 21:51:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 23:14:32 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 23:15:24 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2828c829d001e239e66ba0f7313d37d0cb6e3352
Cr-Commit-Position: refs/heads/master@{#314673}

Powered by Google App Engine
This is Rietveld 408576698