Issue 90243005: Have Locale::create() take a String in argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 90243005: Have Locale::create() take a String in argument (Closed)

Created:
7 years ago by Inactive

Modified:
7 years ago

Reviewers:
abarth-chromium

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have Locale::create() take a String in argument Have Locale::create() take a String in argument instead of an AtomicString as the implementation then converts it back to a String anyway. This also avoids uselessly converting a String a an AtomicString in one of the callers: Locale::defaultLocale(). The languages are stored / exposed as Strings in Language.* R=abarth BUG=323739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162735

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	Source/platform/text/LocaleICU.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/platform/text/LocaleMac.mm	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/platform/text/LocaleWin.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/platform/text/PlatformLocale.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/90243005/1

7 years ago (2013-11-27 02:39:03 UTC) #3

Message was sent while issue was closed.

Change committed as 162735

Expand Messages | Collapse Messages