Issue 90243002: Extract CreateInitProcessReaper() from the Zygote.

Issue 90243002: Extract CreateInitProcessReaper() from the Zygote. (Closed)

Created:
7 years ago by jln (very slow on Chromium)

Modified:
7 years ago

Reviewers:
Jorge Lucangeli Obes

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Extract CreateInitProcessReaper() from the Zygote. CreateInitProcessReaper() is useful for the CLONE_NEWUSER-based sandbox as well as for the current Zygote. Extract it so that it can be used independantly of content/. CreateInitProcessReaper() is now exposed to content through the setuid sandbox client. BUG=312380 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237518

Patch Set 1 #

Patch Set 2 : Move API to sandbox/linux/services #

Total comments: 1

Patch Set 3 : DCHECK ignored return values #

Patch Set 4 : minor style issue. #

Total comments: 4

Patch Set 5 : Address comments. #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -75 lines)			Patch
M	content/zygote/zygote_main_linux.cc	View	1	3 chunks	+11 lines, -75 lines	0 comments	Download
M	sandbox/linux/sandbox_linux.gypi	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
A	sandbox/linux/services/init_process_reaper.h	View	1 2 3 4	1 chunk	+23 lines, -0 lines	0 comments	Download
A	sandbox/linux/services/init_process_reaper.cc	View	1 2 3 4	1 chunk	+103 lines, -0 lines	0 comments	Download
M	sandbox/linux/suid/client/setuid_sandbox_client.h	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	sandbox/linux/suid/client/setuid_sandbox_client.cc	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jln (very slow on Chromium)

Jorge, please take a look! I tried to make this easier to review by making ...

7 years ago (2013-11-27 01:55:29 UTC) #1

Jorge Lucangeli Obes

https://codereview.chromium.org/90243002/diff/60001/sandbox/linux/services/init_process_reaper.cc File sandbox/linux/services/init_process_reaper.cc (right): https://codereview.chromium.org/90243002/diff/60001/sandbox/linux/services/init_process_reaper.cc#newcode30 sandbox/linux/services/init_process_reaper.cc:30: LOG(ERROR) << "Failed to create socketpair"; PLOG? https://codereview.chromium.org/90243002/diff/60001/sandbox/linux/services/init_process_reaper.h File ...

7 years ago (2013-11-27 02:31:53 UTC) #2

jln (very slow on Chromium)

Thanks, PTAL! https://codereview.chromium.org/90243002/diff/60001/sandbox/linux/services/init_process_reaper.cc File sandbox/linux/services/init_process_reaper.cc (right): https://codereview.chromium.org/90243002/diff/60001/sandbox/linux/services/init_process_reaper.cc#newcode30 sandbox/linux/services/init_process_reaper.cc:30: LOG(ERROR) << "Failed to create socketpair"; On ...

7 years ago (2013-11-27 02:37:14 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/90243002/70001

7 years ago (2013-11-27 02:47:18 UTC) #5

Message was sent while issue was closed.

Change committed as 237518

Expand Messages | Collapse Messages