Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 902423002: X87: new classes: special construct stub for derived classs and TDZ for `this`. (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: new classes: special construct stub for derived classs and TDZ for `this`. port 6f97a4948f1495a9b9d60b7f495d0e0efeaa1006 (r26409) original commit message: new classes: special construct stub for derived classs and TDZ for `this`. BUG= R=weiliang.lin@intel.com Committed: https://chromium.googlesource.com/v8/v8/+/91d9054350b82e5e97f51354252a54bb78aee356

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -2 lines) Patch
M src/x87/builtins-x87.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 3 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL. thanks
5 years, 10 months ago (2015-02-09 07:02:27 UTC) #2
Weiliang
lgtm
5 years, 10 months ago (2015-02-09 07:15:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902423002/1
5 years, 10 months ago (2015-02-09 07:16:07 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/91d9054350b82e5e97f51354252a54bb78aee356 Cr-Commit-Position: refs/heads/master@{#26512}
5 years, 10 months ago (2015-02-09 08:06:22 UTC) #6
chunyang.dai
5 years, 10 months ago (2015-02-09 08:06:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
91d9054350b82e5e97f51354252a54bb78aee356 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698