Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 902313002: Enclose break_iterator code with !UCONFIG_NO_BREAK_ITERATOR (Closed)

Created:
5 years, 10 months ago by jungshik at Google
Modified:
5 years, 4 months ago
CC:
v8-dev, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Enclose break_iterator code with !UCONFIG_NO_BREAK_ITERATOR BreakIterator is not a part of the ECMA spec, yet. Some 'embedders' want to save space by not including the dictionary/code for break iterator in ICU. Include v8's break iterator code only when ICU has break iterator. Original patch by srl295@gmail.com BUG=v8:3345 LOG=Y

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -5 lines) Patch
M src/i18n.h View 3 chunks +4 lines, -1 line 0 comments Download
M src/i18n.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/runtime-i18n.cc View 9 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
jungshik at Google
PTAL. Thanks
5 years, 10 months ago (2015-02-07 01:56:46 UTC) #2
Michael Hablich
5 years, 10 months ago (2015-02-23 15:21:16 UTC) #3
On 2015/02/07 01:56:46, Jungshik at google wrote:
> PTAL. Thanks

You can remove me from the reviewers list and add me to CC as I am the TPM ;-)

Powered by Google App Engine
This is Rietveld 408576698