Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 902303002: Move NetworkChangeNotifier initialization after MessageLoop creation. (Closed)

Created:
5 years, 10 months ago by Sergey Ulanov
Modified:
5 years, 10 months ago
Reviewers:
weitao
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move NetworkChangeNotifier initialization after MessageLoop creation. NetworkChangeNotifier was moved to HostProcessMain in crrev.com/314165. On windows it must be initialized after MessageLoop for the calling thread is created, so the host was failing to start. Committed: https://crrev.com/1a435b6d09379ed7f120748f73d5599f37a03ab8 Cr-Commit-Position: refs/heads/master@{#315159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M remoting/host/remoting_me2me_host.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sergey Ulanov
5 years, 10 months ago (2015-02-07 01:00:10 UTC) #2
weitao
On 2015/02/07 01:00:10, Sergey Ulanov wrote: LGTM
5 years, 10 months ago (2015-02-07 01:29:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902303002/1
5 years, 10 months ago (2015-02-07 01:30:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-07 02:01:46 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 02:02:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a435b6d09379ed7f120748f73d5599f37a03ab8
Cr-Commit-Position: refs/heads/master@{#315159}

Powered by Google App Engine
This is Rietveld 408576698