Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 902293002: Only set a valid surface from html_viewer (Closed)

Created:
5 years, 10 months ago by DaveMoore
Modified:
5 years, 10 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only set a valid surface from html_viewer We have users of html_viewer that do not use the mojo provided services, including the surface service. This change: https://codereview.chromium.org/869343004/ broke them I think it's right to check this here. Another option would be to do it in layer_tree_host.cc BUG= Committed: https://crrev.com/0b46750604491453c46480ab985fec398f97c86e Cr-Commit-Position: refs/heads/master@{#315157}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M mojo/services/html_viewer/weblayertreeview_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
DaveMoore
5 years, 10 months ago (2015-02-07 00:16:50 UTC) #2
jamesr
If this embedder of html_viewer doesn't wanna render then we could cut out a lot ...
5 years, 10 months ago (2015-02-07 00:39:14 UTC) #3
jamesr
I think this'll work short term, but look at content::RenderWidget::never_visible_. That's something closer to what ...
5 years, 10 months ago (2015-02-07 00:50:24 UTC) #4
DaveMoore
On 2015/02/07 00:39:14, jamesr wrote: > If this embedder of html_viewer doesn't wanna render then ...
5 years, 10 months ago (2015-02-07 00:52:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902293002/1
5 years, 10 months ago (2015-02-07 01:35:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-07 01:58:17 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 01:58:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b46750604491453c46480ab985fec398f97c86e
Cr-Commit-Position: refs/heads/master@{#315157}

Powered by Google App Engine
This is Rietveld 408576698