Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 902263002: Enable compiling mjsunit tests as ES6 modules (Closed)

Created:
5 years, 10 months ago by adamk
Modified:
5 years, 10 months ago
Reviewers:
rossberg
CC:
v8-dev, arv (Not doing code reviews), Michael Achenbach, yangguo
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Enable compiling mjsunit tests as ES6 modules Adding the line "// MODULE" to an mjsunit file will now cause run-tests.py to prefix the test case with "--module" in the d8 commandline. d8 has itself been updated to treat files preceded with "--module" as modules (that is, it compiles them with ScriptCompiler::CompileModule, and turns on --harmony-modules). Committed: https://crrev.com/a18b797fd96730bc9407d27195fac66f44865004 Cr-Commit-Position: refs/heads/master@{#26555}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -142 lines) Patch
M src/d8.h View 1 chunk +9 lines, -7 lines 0 comments Download
M src/d8.cc View 8 chunks +88 lines, -68 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/test-modules.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D test/mjsunit/harmony/module-parsing.js View 1 chunk +0 lines, -41 lines 0 comments Download
A + test/mjsunit/harmony/module-parsing-eval.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/harmony/modules.js View 1 chunk +4 lines, -1 line 0 comments Download
M test/mjsunit/testcfg.py View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
adamk
Not sure who the best reviewers are for the d8 and testcfg changes. CCed machenbach ...
5 years, 10 months ago (2015-02-06 21:59:05 UTC) #2
adamk
ping?
5 years, 10 months ago (2015-02-09 19:29:34 UTC) #3
rossberg
lgtm
5 years, 10 months ago (2015-02-10 13:07:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902263002/1
5 years, 10 months ago (2015-02-10 17:41:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-10 19:11:49 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 19:12:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a18b797fd96730bc9407d27195fac66f44865004
Cr-Commit-Position: refs/heads/master@{#26555}

Powered by Google App Engine
This is Rietveld 408576698