net/quic/quic_connection_test.cc - Issue 902243003: Remove FLAGS_quic_allow_silent_close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_connection_test.cc

Issue 902243003: Remove FLAGS_quic_allow_silent_close. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Keep_an_instance_of_QuicAckFrame_85351635

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_connection_test.cc

diff --git a/net/quic/quic_connection_test.cc b/net/quic/quic_connection_test.cc

index 47588d0f060e0ac7475b3d8d79430ffc3e38d905..dea91866984b1a928eb86a6921a930b9c949fff6 100644

--- a/net/quic/quic_connection_test.cc

+++ b/net/quic/quic_connection_test.cc

@@ -3156,7 +3156,6 @@ TEST_P(QuicConnectionTest, TimeoutAfterSend) {

TEST_P(QuicConnectionTest, TimeoutAfterSendSilentClose) {

// Same test as above, but complete a handshake which enables silent close,

// causing no connection close packet to be sent.

- ValueRestore<bool> old_flag(&FLAGS_quic_allow_silent_close, true);

EXPECT_TRUE(connection_.connected());

EXPECT_CALL(*send_algorithm_, SetFromConfig(_, _, _));

QuicConfig config;

« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_flags.h » ('j') | no next file with comments »