Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 902213002: Move BluetoothSocketApiTest into extensions_browsertests (Closed)

Created:
5 years, 10 months ago by James Cook
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move BluetoothSocketApiTest into extensions_browsertests It doesn't need to run in Chrome's browser_tests. BUG=388893 TEST=browser_tests and extensions_browsertests for Bluetooth* Committed: https://crrev.com/49fec4b43edc61f40fe8574921e6a26509452dc8 Cr-Commit-Position: refs/heads/master@{#315090}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -292 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/bluetooth_socket/connect/manifest.json View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/test/data/extensions/api_test/bluetooth_socket/connect/runtest.js View 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/test/data/extensions/api_test/bluetooth_socket/listen/manifest.json View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/test/data/extensions/api_test/bluetooth_socket/listen/runtest.js View 1 chunk +0 lines, -131 lines 0 comments Download
D chrome/test/data/extensions/api_test/bluetooth_socket/permission_denied/manifest.json View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/test/data/extensions/api_test/bluetooth_socket/permission_denied/runtest.js View 1 chunk +0 lines, -12 lines 0 comments Download
M extensions/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/browser/api/bluetooth_socket/bluetooth_socket_apitest.cc View 8 chunks +10 lines, -13 lines 0 comments Download
M extensions/extensions_tests.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
A + extensions/test/data/api_test/bluetooth_socket/connect/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/api_test/bluetooth_socket/connect/runtest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/api_test/bluetooth_socket/listen/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/api_test/bluetooth_socket/listen/runtest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/api_test/bluetooth_socket/permission_denied/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/api_test/bluetooth_socket/permission_denied/runtest.js View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
James Cook
rockot, PTAL
5 years, 10 months ago (2015-02-06 18:56:30 UTC) #2
Ken Rockot(use gerrit already)
nice, lgtm
5 years, 10 months ago (2015-02-06 19:09:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902213002/1
5 years, 10 months ago (2015-02-06 19:19:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 19:57:39 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 19:58:07 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/49fec4b43edc61f40fe8574921e6a26509452dc8
Cr-Commit-Position: refs/heads/master@{#315090}

Powered by Google App Engine
This is Rietveld 408576698