Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: ppapi/native_client/src/shared/ppapi_proxy/proxy_var_cache.h

Issue 9022021: Proxy PPB_ArrayBuffer_Dev, make them work over Messaging (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comment. Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/shared/ppapi_proxy/proxy_var_cache.h
diff --git a/ppapi/native_client/src/shared/ppapi_proxy/proxy_var_cache.h b/ppapi/native_client/src/shared/ppapi_proxy/proxy_var_cache.h
index 6cec6d457a8ed0bbce819749cc066f6487155438..4e92ff287b44031e4e12e26b9613e5806930d0f8 100644
--- a/ppapi/native_client/src/shared/ppapi_proxy/proxy_var_cache.h
+++ b/ppapi/native_client/src/shared/ppapi_proxy/proxy_var_cache.h
@@ -54,12 +54,8 @@ class ProxyVarCache {
private:
// Return whether or not a var type is cached.
- // Note to implementers: be sure to add to this function when adding new
- // cached types.
- // TODO(dspringer): When all the complex var types are handled, this
- // test can turn into something like var.type >= PP_VARTYPE_STRING.
bool IsCachedType(const PP_Var& var) {
- return var.type == PP_VARTYPE_STRING || var.type == PP_VARTYPE_OBJECT;
+ return var.type >= PP_VARTYPE_STRING;
}
// The cache of these objects. The value is a shared pointer so that

Powered by Google App Engine
This is Rietveld 408576698