Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 902193002: Update comment about additional_res_packages in java_apk.gypi (Closed)

Created:
5 years, 10 months ago by mstrum
Modified:
5 years, 10 months ago
Reviewers:
cjhopman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update comment about additional_res_packages in java_apk.gypi additional_res_dirs was removed and additional_res_packages does not use it anymore. Committed: https://crrev.com/d3938590973c69a6a05c223acfc2ea7d10d9f838 Cr-Commit-Position: refs/heads/master@{#315163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M build/java_apk.gypi View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mstrum
PTAL
5 years, 10 months ago (2015-02-06 17:31:03 UTC) #2
cjhopman
lgtm
5 years, 10 months ago (2015-02-07 01:11:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902193002/1
5 years, 10 months ago (2015-02-07 01:13:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-07 02:34:21 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 02:34:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3938590973c69a6a05c223acfc2ea7d10d9f838
Cr-Commit-Position: refs/heads/master@{#315163}

Powered by Google App Engine
This is Rietveld 408576698