Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 902143002: Clean up V4L2 codec-related flags and defines (Closed)

Created:
5 years, 10 months ago by henryhsu
Modified:
5 years, 10 months ago
Reviewers:
Pawel Osciak, piman
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up V4L2 codec-related flags and defines All arm platforms support V4L2 SVDA by default and use_v4l2_codec also governs V4L2 VDA/VEA now. Generates libv4l2 stub in GN file. This CL is re-landed because CL 828063009 is reverted by 902773003. BUG=449883, 455545 TEST=build chrome and vda unittest on peach_pit, veyron_pinky, squawks, and panther_freon TBR=piman@chromium.org,posciak@chromium.org Committed: https://crrev.com/5159267af557f4bfab7ff750e4be69d12f452d6c Cr-Commit-Position: refs/heads/master@{#315226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -62 lines) Patch
M content/common/BUILD.gn View 2 chunks +58 lines, -8 lines 0 comments Download
M content/common/common.gni View 1 chunk +5 lines, -4 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M content/common/gpu/media/gpu_video_encode_accelerator.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M content/content_common.gypi View 2 chunks +17 lines, -27 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902143002/1
5 years, 10 months ago (2015-02-06 17:18:33 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-06 17:18:35 UTC) #4
Pawel Osciak
lgtm
5 years, 10 months ago (2015-02-08 04:07:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902143002/1
5 years, 10 months ago (2015-02-08 04:07:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-08 05:01:07 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-08 05:01:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5159267af557f4bfab7ff750e4be69d12f452d6c
Cr-Commit-Position: refs/heads/master@{#315226}

Powered by Google App Engine
This is Rietveld 408576698