Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2883)

Unified Diff: chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc

Issue 902133002: Pointing AppRTC browser test to new location. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed webrtc.DEPS path. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
diff --git a/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc b/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
index cae9ef8d053b718490cd7344a78052f70fc648b1..5a20b395f06007679f225314c4e5d51c138eb5b5 100644
--- a/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
+++ b/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
@@ -27,8 +27,8 @@ const char kAdviseOnGclientSolution[] =
"You need to add this solution to your .gclient to run this test:\n"
"{\n"
" \"name\" : \"webrtc.DEPS\",\n"
- " \"url\" : \"svn://svn.chromium.org/chrome/trunk/deps/"
- "third_party/webrtc/webrtc.DEPS\",\n"
+ " \"url\" : \"https://chromium.googlesource.com/chromium/deps/"
+ "webrtc/webrtc.DEPS\",\n"
"}";
const char kTitlePageOfAppEngineAdminPage[] = "Instances";
@@ -86,13 +86,19 @@ class WebRtcApprtcBrowserTest : public WebRtcTestBase {
}
base::FilePath apprtc_dir =
- GetSourceDir().Append(FILE_PATH_LITERAL(
- "out/webrtc-samples/samples/web/content/apprtc"));
+ GetSourceDir().Append(FILE_PATH_LITERAL("out/apprtc/out/app_engine"));
if (!base::PathExists(apprtc_dir)) {
- LOG(ERROR) << "Missing AppRTC code at " <<
+ LOG(ERROR) << "Missing AppRTC AppEngine app at " <<
apprtc_dir.value() << ". " << kAdviseOnGclientSolution;
return false;
}
+ if (!base::PathExists(apprtc_dir.Append(FILE_PATH_LITERAL("app.yaml")))) {
+ LOG(ERROR) << "The AppRTC AppEngine app at " <<
+ apprtc_dir.value() << " appears to have not been built." <<
+ "This should have been done by webrtc.DEPS scripts which invoke " <<
+ "'grunt build' on AppRTC.";
+ return false;
+ }
base::CommandLine command_line(base::CommandLine::NO_PROGRAM);
EXPECT_TRUE(GetPythonCommand(&command_line));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698