src/full-codegen.cc - Issue 902093002: Add basic compilation support for modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen.cc

Issue 902093002: Add basic compilation support for modules (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen.cc

diff --git a/src/full-codegen.cc b/src/full-codegen.cc

index e72dc7c5fdb3f832c76440affd7545bbc0035ea2..6098e547ee365322f4718ad832c0dbe7bb434d68 100644

--- a/src/full-codegen.cc

+++ b/src/full-codegen.cc

@@ -726,8 +726,8 @@ void FullCodeGenerator::VisitDeclarations(

if (scope_->num_modules() != 0) {

// Initialize modules from descriptor array.

- DCHECK(module_index_ == modules_->length());

- DeclareModules(modules_);

+ // DCHECK(module_index_ == modules_->length());

+ // DeclareModules(modules_);

rossberg 2015/02/06 12:36:56 Is this stray? Or a TODO?

adamk 2015/02/06 17:29:08 Oops. This is a TODO, I thought I'd managed to fix

modules_ = saved_modules;

module_index_ = saved_module_index;

}

« src/compiler.cc ('K') | « src/debug.cc ('k') | src/parser.h » ('j') | no next file with comments »