Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 902083004: Revert "Remove test retrying for Safari, in test scripts." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 2606 matching lines...) Expand 10 before | Expand all | Expand 10 after
2617 Future cleanup() => new Future.value(); 2617 Future cleanup() => new Future.value();
2618 2618
2619 Future<CommandOutput> runCommand(node, ProcessCommand command, int timeout) { 2619 Future<CommandOutput> runCommand(node, ProcessCommand command, int timeout) {
2620 assert(node.dependencies.length == 0); 2620 assert(node.dependencies.length == 0);
2621 return new Future.value(_archive.outputOf(command)); 2621 return new Future.value(_archive.outputOf(command));
2622 } 2622 }
2623 } 2623 }
2624 2624
2625 bool shouldRetryCommand(CommandOutput output) { 2625 bool shouldRetryCommand(CommandOutput output) {
2626 var command = output.command; 2626 var command = output.command;
2627 // We rerun tests on Safari because 6.2 and 7.1 are flaky. Issue 21434.
2628 if (command is BrowserTestCommand &&
2629 command.retry &&
2630 command.browser == 'safari' &&
2631 output is BrowserControllerTestOutcome &&
2632 output._rawOutcome != Expectation.PASS) {
2633 return true;
2634 }
2635
2627 if (!output.successful) { 2636 if (!output.successful) {
2628 List<String> stdout, stderr; 2637 List<String> stdout, stderr;
2629 2638
2630 decodeOutput() { 2639 decodeOutput() {
2631 if (stdout == null && stderr == null) { 2640 if (stdout == null && stderr == null) {
2632 stdout = decodeUtf8(output.stderr).split("\n"); 2641 stdout = decodeUtf8(output.stderr).split("\n");
2633 stderr = decodeUtf8(output.stderr).split("\n"); 2642 stderr = decodeUtf8(output.stderr).split("\n");
2634 } 2643 }
2635 } 2644 }
2636 2645
(...skipping 309 matching lines...) Expand 10 before | Expand all | Expand 10 after
2946 } 2955 }
2947 } 2956 }
2948 2957
2949 void eventAllTestsDone() { 2958 void eventAllTestsDone() {
2950 for (var listener in _eventListener) { 2959 for (var listener in _eventListener) {
2951 listener.allDone(); 2960 listener.allDone();
2952 } 2961 }
2953 _allDone(); 2962 _allDone();
2954 } 2963 }
2955 } 2964 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698