Only increment the history list offset if we are not replacing the current item.

content/browser/frame_host/navigation_controller_impl_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/strings/stringprintf.h"
 #include "content/browser/frame_host/frame_tree.h"
 #include "content/browser/frame_host/navigation_controller_impl.h"
 #include "content/browser/frame_host/navigation_entry_impl.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/content_browser_test.h"
 #include "content/public/test/content_browser_test_utils.h"
+#include "content/public/test/test_navigation_observer.h"
 #include "content/public/test/test_utils.h"
 #include "content/shell/browser/shell.h"
 #include "content/test/content_browser_test_utils_internal.h"
 #include "net/dns/mock_host_resolver.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 
 namespace content {
 
 class NavigationControllerBrowserTest : public ContentBrowserTest {
  protected:
@@ skipping 55 matching lines @@
   // Now try to go back. This should not hang.
   ASSERT_TRUE(controller.CanGoBack());
   controller.GoBack();
   EXPECT_TRUE(WaitForLoadStop(shell()->web_contents()));
 
   // This should have successfully gone back.
   EXPECT_EQ(GURL(base::StringPrintf("data:text/html,page%d", kMaxEntryCount)),
             controller.GetLastCommittedEntry()->GetURL());
 }
 
+namespace {
+
+int RendererHistoryLength(Shell* shell) {
+  int value = 0;
+  EXPECT_TRUE(ExecuteScriptAndExtractInt(
+      shell->web_contents(),
+      "domAutomationController.send(history.length)",
+      &value));
+  return value;
+}
+
+// Similar to the ones from content_browser_test_utils.
+bool NavigateToURLAndReplace(Shell* shell, const GURL& url) {
+  WebContents* web_contents = shell->web_contents();
+  WaitForLoadStop(web_contents);
+  TestNavigationObserver same_tab_observer(web_contents, 1);
+  NavigationController::LoadURLParams params(url);
+  params.should_replace_current_entry = true;
+  web_contents->GetController().LoadURLWithParams(params);
+  web_contents->Focus();

[Charlie Reis, 2015/02/06 17:29:35]

Is this line needed?  I don't see why the focus would change, and I didn't see
similar calls in content_browser_test_utils.

[Avi (use Gerrit), 2015/02/06 17:43:14]

In content_browser_test_utils, NavigateToURLBlockUntilNavigationsComplete has
"window->LoadURL()". That is Shell::LoadURL, which calls through to
Shell::LoadURLForFrame which does exactly what I do in my test.

This is an unrolling of all the calls into one linear function. I don't know
what would happen, but I wanted to keep in line with what all the other versions
of this function do.

+  same_tab_observer.Wait();
+  if (!IsLastCommittedEntryOfPageType(web_contents, PAGE_TYPE_NORMAL))
+    return false;
+  return web_contents->GetLastCommittedURL() == url;
+}
+
+}  // namespace
+
+// When loading a new page to replace an old page in the history list, make sure
+// that the browser and renderer agree, and that both get it right.
+IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest,
+                       CorrectLengthWithCurrentItemReplacement) {
+  NavigationController& controller =
+      shell()->web_contents()->GetController();
+
+  EXPECT_TRUE(NavigateToURL(shell(), GURL("data:text/html,page1")));
+  EXPECT_EQ(1, controller.GetEntryCount());
+  EXPECT_EQ(1, RendererHistoryLength(shell()));
+
+  EXPECT_TRUE(NavigateToURLAndReplace(shell(), GURL("data:text/html,page2")));
+  EXPECT_EQ(1, controller.GetEntryCount());
+  EXPECT_EQ(1, RendererHistoryLength(shell()));
+
+  // Note that there's no way to access the renderer's notion of the history
+  // offset via JavaScript. Checking just the history length, though, is enough;
+  // if the replacement failed, there would be a new history entry and thus an
+  // incorrect length.
+}
+
+namespace {
+
 struct FrameNavigateParamsCapturer : public WebContentsObserver {
  public:
   explicit FrameNavigateParamsCapturer(FrameTreeNode* node)
       : WebContentsObserver(
             node->current_frame_host()->delegate()->GetAsWebContents()),
         frame_tree_node_id_(node->frame_tree_node_id()),
         message_loop_runner_(new MessageLoopRunner) {}
 
   void Wait() {
     message_loop_runner_->Run();
@@ skipping 27 matching lines @@
   // The params of the last navigation.
   FrameNavigateParams params_;
 
   // The details of the last navigation.
   LoadCommittedDetails details_;
 
   // The MessageLoopRunner used to spin the message loop.
   scoped_refptr<MessageLoopRunner> message_loop_runner_;
 };
 
+}  // namespace
+
 // Verify that the distinction between manual and auto subframes is properly set
 // for subframe navigations. TODO(avi): It's rather bogus that the same info is
 // in two different enums; http://crbug.com/453555.
 IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest,
                        ManualAndAutoSubframeNavigationClassification) {
   GURL main_url(
       embedded_test_server()->GetURL("/frame_tree/page_with_one_frame.html"));
   NavigateToURL(shell(), main_url);
 
   // It is safe to obtain the root frame tree node here, as it doesn't change.
@@ skipping 41 matching lines @@
         embedded_test_server()->GetURL("/frame_tree/2-3.html"));
     NavigateFrameToURL(root->child_at(0), frame_url);
     capturer.Wait();
     EXPECT_EQ(ui::PAGE_TRANSITION_MANUAL_SUBFRAME,
               capturer.params().transition);
     EXPECT_EQ(NAVIGATION_TYPE_NEW_SUBFRAME, capturer.details().type);
   }
 }
 
 }  // namespace content