chrome/browser/resources/md_settings/md_settings.html - Issue 902053003: Add cr-toggle-button to Chrome

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_settings/md_settings.html

Issue 902053003: Add cr-toggle-button to Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more renames; add to chrome://md-settings Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title>Settings</title>	5 <title>Settings</title>

6 <link rel="import"	6 <link rel="import"

7 href="chrome://resources/polymer/paper-button/paper-button.html">	7 href="chrome://resources/polymer/paper-button/paper-button.html">

	8 <link rel="import"

	9 href="chrome://resources/cr_elements/cr_toggle_button/cr-toggle-button.htm l">

8 </head>	10 </head>

9 <body>	11 <body>

10 <header>	12 <header>

11 <h1>Settings</h1>	13 <h1>Settings</h1>

12 </header>	14 </header>

13 <div class="main">	15 <div class="main">

14 <paper-button id="manage-button" raised>Manage</paper-button>	16 <paper-button id="manage-button" raised>Manage</paper-button>

15 </div>	17 </div>

	18 <p>
	Jeremy Klein 2015/02/09 18:24:51 Nit: Not that it matters at this point, but I don' Nit: Not that it matters at this point, but I don't think <p> is the right tag to use here. Maybe <div> or <section>? Oren Blasberg 2015/02/09 18:27:32 Or just move this <p>...</p> block within the 'mai Show quoted text On 2015/02/09 18:24:51, Jeremy Klein wrote: > Nit: Not that it matters at this point, but I don't think <p> is the right tag > to use here. Maybe <div> or <section>? Or just move this <p>...</p> block within the 'main' div above. michaelpg 2015/02/09 22:11:19 Done. Show quoted text On 2015/02/09 18:24:51, Jeremy Klein wrote: > Nit: Not that it matters at this point, but I don't think <p> is the right tag > to use here. Maybe <div> or <section>? Done.
	19 <cr-toggle-button checked></cr-toggle-button>

	20 </p>

16 </body>	21 </body>

17 </html>	22 </html>

OLD	NEW

« no previous file with comments | « no previous file | content/browser/webui/shared_resources_data_source.cc » ('j') | ui/webui/resources/cr_elements/cr_toggle_button/cr-toggle-button.js » ('J')