ui/webui/resources/cr_element_resources.grdp - Issue 902053003: Add cr-toggle-button to Chrome

Side by Side Diff: ui/webui/resources/cr_element_resources.grdp

Issue 902053003: Add cr-toggle-button to Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Renames, expand cr-events, style cr-toggle-button Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <grit-part>

	3 <structure name="IDR_CR_ELEMENTS_TOGGLE_BUTTON_CR_TOGGLE_BUTTON_CSS"
	James Hawkins 2015/02/06 15:19:10 The IDR name is long enough to seem unmanageable. The IDR name is long enough to seem unmanageable. Is it so because we are concerned about clashing? stevenjb 2015/02/06 17:50:30 I would suggest that the CR_ELEMENTS_TOGGLE_BUTTON Show quoted text On 2015/02/06 15:19:10, James Hawkins wrote: > The IDR name is long enough to seem unmanageable. Is it so because we are > concerned about clashing? I would suggest that the CR_ELEMENTS_TOGGLE_BUTTON bit is unnecessary. We should name our custom elements uniquely / descriptively. michaelpg 2015/02/06 21:32:02 I thought it was just convention to use the path. Show quoted text On 2015/02/06 17:50:30, stevenjb wrote: > On 2015/02/06 15:19:10, James Hawkins wrote: > > The IDR name is long enough to seem unmanageable. Is it so because we are > > concerned about clashing? > > I would suggest that the CR_ELEMENTS_TOGGLE_BUTTON bit is unnecessary. We should > name our custom elements uniquely / descriptively. I thought it was just convention to use the path. We don't have to worry about clashing here. stevenjb 2015/02/09 18:33:00 Thinking about this more, I would keep the CR_ELEM Show quoted text On 2015/02/06 17:50:30, stevenjb wrote: > On 2015/02/06 15:19:10, James Hawkins wrote: > > The IDR name is long enough to seem unmanageable. Is it so because we are > > concerned about clashing? > > I would suggest that the CR_ELEMENTS_TOGGLE_BUTTON bit is unnecessary. We should > name our custom elements uniquely / descriptively. Thinking about this more, I would keep the CR_ELEMENTS, but remove the redundant TOGGLE_BUTTON. michaelpg 2015/02/09 22:11:19 Done. Show quoted text On 2015/02/09 18:33:00, stevenjb wrote: > On 2015/02/06 17:50:30, stevenjb wrote: > > On 2015/02/06 15:19:10, James Hawkins wrote: > > > The IDR name is long enough to seem unmanageable. Is it so because we are > > > concerned about clashing? > > > > I would suggest that the CR_ELEMENTS_TOGGLE_BUTTON bit is unnecessary. We > should > > name our custom elements uniquely / descriptively. > Thinking about this more, I would keep the CR_ELEMENTS, but remove the redundant > TOGGLE_BUTTON. > Done.
	4 file="../../webui/resources/cr_elements/toggle-button/cr-toggle-but ton.css"

	5 type="chrome_html" />

	6 <structure name="IDR_CR_ELEMENTS_TOGGLE_BUTTON_CR_TOGGLE_BUTTON_HTML"

	7 file="../../webui/resources/cr_elements/toggle-button/cr-toggle-but ton.html"

	8 type="chrome_html" />

	9 <structure name="IDR_CR_ELEMENTS_TOGGLE_BUTTON_CR_TOGGLE_BUTTON_JS"

	10 file="../../webui/resources/cr_elements/toggle-button/cr-toggle-but ton.js"

	11 type="chrome_html" />

	12 <structure name="IDR_CR_ELEMENTS_EVENTS_CR_EVENTS_HTML"

	13 file="../../webui/resources/cr_elements/events/cr-events.html"

	14 type="chrome_html" />

	15 <structure name="IDR_CR_ELEMENTS_EVENTS_CR_EVENTS_JS"

	16 file="../../webui/resources/cr_elements/events/cr-events.js"

	17 type="chrome_html" />

	18 </grit-part>

OLD	NEW

« no previous file with comments | « content/browser/webui/shared_resources_data_source.cc ('k') | ui/webui/resources/cr_elements/events/cr-events.html » ('j') | no next file with comments »