Remoting_nacl build shouldn't need to depend on nacl_irt.

Remoting_nacl build shouldn't need to depend on nacl_irt.

Allow building in parallel. It may be a runtime dependency
but it's not a build-time dependency.

Happened to notice the serialization in the graph:
http://chromium-build-stats.appspot.com/ninja_log/2015/02/05/build48-m1/ninja_log.build48-m1.chrome-bot.20150205-093049.13303.gz/trace.html

BUG=none

Committed: https://crrev.com/fea7dfa8bf43dbba78011dfd3042620db413f199
Cr-Commit-Position: refs/heads/master@{#314941}

[jvoung (off chromium), 2015-02-05 20:18:57]

jvoung@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Wez, 2015-02-05 23:13:24]

Can you clarify what you mean by "may be a runtime dependency"? Are you
saying nacl_irt is bundled w/ Chrome, rather than with the app?

On 5 February 2015 at 12:19, <jvoung@chromium.org> wrote:

> Reviewers: Sergey Ulanov,
>
> Description:
> Remoting_nacl build shouldn't need to depend on nacl_irt.
>
> Allow building in parallel. It may be a runtime dependency
> but it's not a build-time dependency.
>
> Happened to notice the serialization in the graph:
> http://chromium-build-stats.appspot.com/ninja_log/2015/02/
> 05/build48-m1/ninja_log.build48-m1.chrome-bot.20150205-093049.13303.gz/
> trace.html
>
> BUG=none
>
> Please review this at https://codereview.chromium.org/902033002/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+0, -1 lines):
>   M remoting/remoting_nacl.gyp
>
>
> Index: remoting/remoting_nacl.gyp
> diff --git a/remoting/remoting_nacl.gyp b/remoting/remoting_nacl.gyp
> index c54129671b86f7cc6ab44ab680a484cfbfc6b135..
> cb02002fb350b06074165cbbe04e96ee1c733431 100644
> --- a/remoting/remoting_nacl.gyp
> +++ b/remoting/remoting_nacl.gyp
> @@ -182,7 +182,6 @@
>          '../native_client/tools.gyp:prep_toolchain',
>          '../native_client_sdk/native_client_sdk_untrusted.gyp:nacl_
> io_untrusted',
>          '../net/net_nacl.gyp:net_nacl',
> -        '../ppapi/native_client/native_client.gyp:nacl_irt',
>          '../ppapi/native_client/native_client.gyp:ppapi_lib',
>          '../ppapi/ppapi_nacl.gyp:ppapi_cpp_lib',
>          '../third_party/expat/expat_nacl.gyp:expat_nacl',
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jvoung (off chromium), 2015-02-05 23:18:36]

Yes, nacl_irt is bundled w/ Chrome and not with the app. The IRT implementation
evolves with Chrome, while the app can stay the same.

I wasn't sure why nacl_irt was listed here originally, so I assumed it was
because it was required to actually run the app.


On 2015/02/05 23:13:24, Wez wrote:
> Can you clarify what you mean by "may be a runtime dependency"? Are you
> saying nacl_irt is bundled w/ Chrome, rather than with the app?
> 
> On 5 February 2015 at 12:19, <mailto:jvoung@chromium.org> wrote:
> 
> > Reviewers: Sergey Ulanov,
> >
> > Description:
> > Remoting_nacl build shouldn't need to depend on nacl_irt.
> >
> > Allow building in parallel. It may be a runtime dependency
> > but it's not a build-time dependency.
> >
> > Happened to notice the serialization in the graph:
> > http://chromium-build-stats.appspot.com/ninja_log/2015/02/
> > 05/build48-m1/ninja_log.build48-m1.chrome-bot.20150205-093049.13303.gz/
> > trace.html
> >
> > BUG=none
> >
> > Please review this at https://codereview.chromium.org/902033002/
> >
> > Base URL: https://chromium.googlesource.com/chromium/src.git@master
> >
> > Affected files (+0, -1 lines):
> >   M remoting/remoting_nacl.gyp
> >
> >
> > Index: remoting/remoting_nacl.gyp
> > diff --git a/remoting/remoting_nacl.gyp b/remoting/remoting_nacl.gyp
> > index c54129671b86f7cc6ab44ab680a484cfbfc6b135..
> > cb02002fb350b06074165cbbe04e96ee1c733431 100644
> > --- a/remoting/remoting_nacl.gyp
> > +++ b/remoting/remoting_nacl.gyp
> > @@ -182,7 +182,6 @@
> >          '../native_client/tools.gyp:prep_toolchain',
> >          '../native_client_sdk/native_client_sdk_untrusted.gyp:nacl_
> > io_untrusted',
> >          '../net/net_nacl.gyp:net_nacl',
> > -        '../ppapi/native_client/native_client.gyp:nacl_irt',
> >          '../ppapi/native_client/native_client.gyp:ppapi_lib',
> >          '../ppapi/ppapi_nacl.gyp:ppapi_cpp_lib',
> >          '../third_party/expat/expat_nacl.gyp:expat_nacl',
> >
> >
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Sergey Ulanov, 2015-02-06 00:53:37]

lgtm

[jvoung (off chromium), 2015-02-06 01:29:37]

The CQ bit was checked by jvoung@chromium.org

[commit-bot: I haz the power, 2015-02-06 01:30:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/902033002/1

[commit-bot: I haz the power, 2015-02-06 01:37:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-06 01:38:15]

Patchset 1 (id:??) landed as
https://crrev.com/fea7dfa8bf43dbba78011dfd3042620db413f199
Cr-Commit-Position: refs/heads/master@{#314941}