Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 902013002: Add end-to-end page run tests that exercise Web Page Replay. (Closed)

Created:
5 years, 10 months ago by slamm
Modified:
5 years, 10 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add end-to-end page run tests that exercise Web Page Replay. BUG=431686 Committed: https://crrev.com/fff89e0a1de1d6f2f6953a74627fb1049caeab3d Cr-Commit-Position: refs/heads/master@{#314940}

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Patch Set 3 : Better error message for failed WPR test. #

Patch Set 4 : Remove unneeded files #

Patch Set 5 : Add example_domain_001.wpr.sha1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -7 lines) Patch
M tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py View 1 2 4 chunks +26 lines, -5 lines 0 comments Download
A + tools/telemetry/unittest_data/page_sets/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/telemetry/unittest_data/page_sets/data/.gitignore View 1 chunk +1 line, -0 lines 0 comments Download
A + tools/telemetry/unittest_data/page_sets/data/example_domain.json View 1 1 chunk +4 lines, -3 lines 0 comments Download
A tools/telemetry/unittest_data/page_sets/data/example_domain_001.wpr.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A tools/telemetry/unittest_data/page_sets/example_domain.py View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
slamm
5 years, 10 months ago (2015-02-05 21:48:23 UTC) #2
nednguyen
https://codereview.chromium.org/902013002/diff/1/tools/telemetry/unittest_data/page_sets/example_domain.py File tools/telemetry/unittest_data/page_sets/example_domain.py (right): https://codereview.chromium.org/902013002/diff/1/tools/telemetry/unittest_data/page_sets/example_domain.py#newcode9 tools/telemetry/unittest_data/page_sets/example_domain.py:9: class ExampleDomainPageSet(page_set.PageSet): Maybe NonSSLExampleDomainPageSet
5 years, 10 months ago (2015-02-05 22:12:48 UTC) #4
nednguyen
LGTM, your bug number is wrong btw. https://codereview.chromium.org/902013002/diff/1/tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py File tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py (right): https://codereview.chromium.org/902013002/diff/1/tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py#newcode547 tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py:547: [r.page.url for ...
5 years, 10 months ago (2015-02-05 22:15:54 UTC) #5
slamm
Better error message for failed WPR test.
5 years, 10 months ago (2015-02-05 23:21:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902013002/40001
5 years, 10 months ago (2015-02-05 23:25:38 UTC) #9
slamm
Remove unneeded files
5 years, 10 months ago (2015-02-05 23:26:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902013002/60001
5 years, 10 months ago (2015-02-05 23:27:34 UTC) #12
slamm
https://codereview.chromium.org/902013002/diff/1/tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py File tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py (right): https://codereview.chromium.org/902013002/diff/1/tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py#newcode547 tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py:547: [r.page.url for r in GetSuccessfulPageRuns(results)]) On 2015/02/05 22:15:54, nednguyen ...
5 years, 10 months ago (2015-02-05 23:29:12 UTC) #13
slamm
Add example_domain_001.wpr.sha1
5 years, 10 months ago (2015-02-06 00:28:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902013002/80001
5 years, 10 months ago (2015-02-06 00:30:15 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-06 01:30:34 UTC) #20
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 01:31:28 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/fff89e0a1de1d6f2f6953a74627fb1049caeab3d
Cr-Commit-Position: refs/heads/master@{#314940}

Powered by Google App Engine
This is Rietveld 408576698