Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 901963002: Enable ScreenOrientation API by default (Closed)

Created:
5 years, 10 months ago by jonross
Modified:
5 years, 10 months ago
Reviewers:
oshima, jwd
CC:
chromium-reviews, kalyank, jam, sadrul, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable ScreenOrientation API by default Add new flag to disable screen orientation locking. Update ScreenOrientationController to be enabled by default, and to check flag state for disabling. TEST=Set flag to check feature was disabled. BUG=396760 Committed: https://crrev.com/98fccbf697252ed205523a5ff61de0f402b62b8d Cr-Commit-Position: refs/heads/master@{#314895}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M ash/ash_switches.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/ash_switches.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/content/display/screen_orientation_controller_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
jonross
Hi Oshima, Could you review this change? I'm adding a new flag to disable Screen ...
5 years, 10 months ago (2015-02-05 16:15:37 UTC) #4
jonross
jwd@chromium.org: Please review changes in tools/metrics/histograms/histograms.xml I've updated it to reflect the addition of a ...
5 years, 10 months ago (2015-02-05 16:17:10 UTC) #6
oshima
lgtm
5 years, 10 months ago (2015-02-05 19:02:31 UTC) #7
jwd
lgtm
5 years, 10 months ago (2015-02-05 21:11:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901963002/40001
5 years, 10 months ago (2015-02-05 21:13:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 10 months ago (2015-02-05 22:14:28 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 22:16:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98fccbf697252ed205523a5ff61de0f402b62b8d
Cr-Commit-Position: refs/heads/master@{#314895}

Powered by Google App Engine
This is Rietveld 408576698