Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 901923002: cleanup api-natives a bit (Closed)

Created:
5 years, 10 months ago by dcarney
Modified:
5 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

cleanup api-natives a bit R=verwaest@chromium.org BUG= Committed: https://crrev.com/e64810b5a5672f0b3a140d54986d2e02d86bb2a8 Cr-Commit-Position: refs/heads/master@{#26481}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -111 lines) Patch
M src/api.cc View 1 4 chunks +17 lines, -56 lines 0 comments Download
M src/api-natives.h View 1 2 chunks +15 lines, -0 lines 0 comments Download
M src/api-natives.cc View 1 5 chunks +114 lines, -55 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcarney
ptal
5 years, 10 months ago (2015-02-05 13:01:05 UTC) #2
Toon Verwaest
lgtm
5 years, 10 months ago (2015-02-06 09:38:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901923002/20001
5 years, 10 months ago (2015-02-06 09:42:43 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-06 09:44:55 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 09:45:09 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e64810b5a5672f0b3a140d54986d2e02d86bb2a8
Cr-Commit-Position: refs/heads/master@{#26481}

Powered by Google App Engine
This is Rietveld 408576698