Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: Source/core/fetch/ResourceFetcher.cpp

Issue 901903003: CSP: Adding the 'upgrade-insecure-requests' directive. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rearranging. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/fetch/ResourceFetcher.h ('k') | Source/core/frame/csp/CSPDirectiveList.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/fetch/ResourceFetcher.cpp
diff --git a/Source/core/fetch/ResourceFetcher.cpp b/Source/core/fetch/ResourceFetcher.cpp
index d67eb023c759718c5305aaf0c69adfaee7704ab3..f16642c9f5c30c13a430598218e6fd113877e45d 100644
--- a/Source/core/fetch/ResourceFetcher.cpp
+++ b/Source/core/fetch/ResourceFetcher.cpp
@@ -66,6 +66,7 @@
#include "platform/Logging.h"
#include "platform/RuntimeEnabledFeatures.h"
#include "platform/TraceEvent.h"
+#include "platform/weborigin/KnownPorts.h"
#include "platform/weborigin/SchemeRegistry.h"
#include "platform/weborigin/SecurityOrigin.h"
#include "platform/weborigin/SecurityPolicy.h"
@@ -715,6 +716,8 @@ ResourcePtr<Resource> ResourceFetcher::requestResource(Resource::Type type, Fetc
TRACE_EVENT0("blink", "ResourceFetcher::requestResource");
+ maybeUpgradeInsecureRequestURL(request);
+
KURL url = request.resourceRequest().url();
WTF_LOG(ResourceLoading, "ResourceFetcher::requestResource '%s', charset '%s', priority=%d, forPreload=%u, type=%s", url.elidedString().latin1().data(), request.charset().latin1().data(), request.priority(), request.forPreload(), ResourceTypeName(type));
@@ -895,6 +898,23 @@ void ResourceFetcher::addAdditionalRequestHeaders(ResourceRequest& request, Reso
context().addAdditionalRequestHeaders(document(), request, (type == Resource::MainResource) ? FetchMainResource : FetchSubresource);
}
+void ResourceFetcher::maybeUpgradeInsecureRequestURL(FetchRequest& request)
+{
+ if (!m_document)
+ return;
+
+ KURL url = request.resourceRequest().url();
+ if (m_document->insecureContentPolicy() == SecurityContext::InsecureContentUpgrade && url.protocol() == "http") {
Ryan Sleevi 2015/02/05 20:03:04 *cough* ws:// -> wss://
Mike West 2015/02/05 20:19:08 That's going to happen in a followup (somewhere ar
+ url.setProtocol("https");
+ // FIXME: HACKY HACKY HACKY HACKY.
+ if (url.port() == 8000 || url.port() == 8080)
+ url.setPort(8443);
Ryan Sleevi 2015/02/05 20:03:03 wat? No no no
Mike West 2015/02/05 20:19:08 Totally. I did this to make the test work as a PoC
+ else if (url.port() == 80)
+ url.setPort(443);
Ryan Sleevi 2015/02/05 20:03:03 yes yes yes
+ request.mutableResourceRequest().setURL(url);
+ }
+}
+
ResourcePtr<Resource> ResourceFetcher::createResourceForRevalidation(const FetchRequest& request, Resource* resource)
{
ASSERT(resource);
« no previous file with comments | « Source/core/fetch/ResourceFetcher.h ('k') | Source/core/frame/csp/CSPDirectiveList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698