Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 901863002: Revert of Fix the histograms whitelist for the OOP PDF plugin. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang, raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix the histograms whitelist for the OOP PDF plugin. (patchset #1 id:1 of https://codereview.chromium.org/897863003/) Reason for revert: Introduced 2 new static initializers: pepper_uma_host.cc (anonymous namespace)::kWhitelistedPluginBaseNames pepper_uma_host.cc __init_array_end+0x5e8 Original issue's description: > Fix the histograms whitelist for the OOP PDF plugin. > > BUG=405305 > > Committed: https://crrev.com/ad1fecf3841f539281c8d6ff3a873bfc9c11571d > Cr-Commit-Position: refs/heads/master@{#314764} TBR=raymes@chromium.org,thestig@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=405305 Committed: https://crrev.com/c5d93145ccc97b697f0decde9fa10267998e40f4 Cr-Commit-Position: refs/heads/master@{#314776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/renderer/pepper/pepper_uma_host.cc View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dcheng
Created Revert of Fix the histograms whitelist for the OOP PDF plugin.
5 years, 10 months ago (2015-02-05 08:12:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901863002/1
5 years, 10 months ago (2015-02-05 08:13:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 08:14:50 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c5d93145ccc97b697f0decde9fa10267998e40f4 Cr-Commit-Position: refs/heads/master@{#314776}
5 years, 10 months ago (2015-02-05 08:15:45 UTC) #4
Lei Zhang
5 years, 10 months ago (2015-02-05 08:21:49 UTC) #5
Message was sent while issue was closed.
lgtm, bleh

Powered by Google App Engine
This is Rietveld 408576698