Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 901843004: Forcefully set the right gyp variables for 32-bit Linux builds. (Closed)

Created:
5 years, 10 months ago by Lei Zhang
Modified:
5 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Forcefully set the right gyp variables for 32-bit Linux builds. BUG=455572 TBR=thakis@chromium.org Committed: https://crrev.com/cc09711e43f8a71f91af6cbbfe40fb3d2941dc06 Cr-Commit-Position: refs/heads/master@{#314799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Lei Zhang
TBR In my chroot, I'm building with Clang, but gyp thinks $clang is 0 when ...
5 years, 10 months ago (2015-02-05 11:16:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901843004/1
5 years, 10 months ago (2015-02-05 11:18:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 13:58:45 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 13:59:34 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc09711e43f8a71f91af6cbbfe40fb3d2941dc06
Cr-Commit-Position: refs/heads/master@{#314799}

Powered by Google App Engine
This is Rietveld 408576698