third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/generator.py - Issue 901843003: Update mojo sdk to rev 8d45c89c30b230843c5bd6dd0693a555750946c0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/generator.py

Issue 901843003: Update mojo sdk to rev 8d45c89c30b230843c5bd6dd0693a555750946c0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Partial revert of https://codereview.chromium.org/899993002/ Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/data.py ('k') | third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/module.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/generator.py

diff --git a/third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/generator.py b/third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/generator.py

index af14ead8cbc2c8c110467bffb28d101dc3866204..401c399e9e62afd9e54de5196d85ea5eb3f97a9c 100644

--- a/third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/generator.py

+++ b/third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/generator.py

@@ -9,6 +9,7 @@ import os.path

import re

import module as mojom

+import mojom.fileutil as fileutil

import pack

def GetStructFromMethod(method):

@@ -50,8 +51,7 @@ def CamelCaseToAllCaps(camel_case):

def WriteFile(contents, full_path):

# Make sure the containing directory exists.

full_dir = os.path.dirname(full_path)

- if not os.path.exists(full_dir):

- os.makedirs(full_dir)

+ fileutil.EnsureDirectoryExists(full_dir)

# Dump the data to disk.

with open(full_path, "w+") as f: