Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 901833004: [Cast] Repurpose CastInitializationStatus for variable frame size support. (Closed)

Created:
5 years, 10 months ago by miu
Modified:
5 years, 10 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cast] Repurpose CastInitializationStatus for variable frame size support. 1. Renamed the CastInitializationStatus enum to OperationalStatus. 2. Renamed CastInitializationCallback to StatusChangeCallback. 3. Documented use of enum and callback. 4. Callbacks may now be run repeatedly to indicate when codec reinit occurs (e.g., for a frame size change), and whether runtime errors occur after initialization. BUG=451277 Committed: https://crrev.com/6377eb4a7055d3135e286e71b563ccd100ed4669 Cr-Commit-Position: refs/heads/master@{#315187}

Patch Set 1 #

Patch Set 2 : Compile fixes. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+407 lines, -339 lines) Patch
M chrome/renderer/media/cast_session_delegate.h View 1 chunk +10 lines, -5 lines 0 comments Download
M chrome/renderer/media/cast_session_delegate.cc View 4 chunks +43 lines, -34 lines 2 comments Download
M media/cast/cast_config.h View 1 chunk +5 lines, -2 lines 0 comments Download
M media/cast/cast_defines.h View 1 chunk +27 lines, -12 lines 0 comments Download
M media/cast/cast_sender.h View 1 chunk +6 lines, -4 lines 0 comments Download
M media/cast/cast_sender_impl.h View 2 chunks +7 lines, -8 lines 0 comments Download
M media/cast/cast_sender_impl.cc View 5 chunks +27 lines, -17 lines 0 comments Download
M media/cast/receiver/audio_decoder.h View 1 chunk +4 lines, -4 lines 0 comments Download
M media/cast/receiver/audio_decoder.cc View 6 chunks +15 lines, -17 lines 0 comments Download
M media/cast/receiver/audio_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/receiver/video_decoder.h View 1 chunk +4 lines, -4 lines 0 comments Download
M media/cast/receiver/video_decoder.cc View 7 chunks +15 lines, -17 lines 0 comments Download
M media/cast/receiver/video_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/audio_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/audio_encoder.cc View 11 chunks +20 lines, -22 lines 0 comments Download
M media/cast/sender/audio_sender.h View 1 chunk +1 line, -7 lines 0 comments Download
M media/cast/sender/audio_sender.cc View 4 chunks +13 lines, -8 lines 0 comments Download
M media/cast/sender/audio_sender_unittest.cc View 2 chunks +17 lines, -1 line 0 comments Download
M media/cast/sender/external_video_encoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/sender/external_video_encoder.cc View 12 chunks +30 lines, -25 lines 0 comments Download
M media/cast/sender/external_video_encoder_unittest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M media/cast/sender/frame_sender.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/cast/sender/h264_vt_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/h264_vt_encoder.cc View 1 1 chunk +11 lines, -15 lines 0 comments Download
M media/cast/sender/h264_vt_encoder_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M media/cast/sender/video_encoder_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/video_encoder_impl.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M media/cast/sender/video_encoder_impl_unittest.cc View 4 chunks +10 lines, -1 line 0 comments Download
M media/cast/sender/video_sender.h View 3 chunks +1 line, -9 lines 0 comments Download
M media/cast/sender/video_sender.cc View 8 chunks +14 lines, -23 lines 0 comments Download
M media/cast/sender/video_sender_unittest.cc View 18 chunks +57 lines, -35 lines 0 comments Download
M media/cast/test/cast_benchmarks.cc View 1 3 chunks +22 lines, -13 lines 0 comments Download
M media/cast/test/end2end_unittest.cc View 2 chunks +10 lines, -12 lines 0 comments Download
M media/cast/test/sender.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M media/cast/test/simulator.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
miu
hclam: PTAL.
5 years, 10 months ago (2015-02-05 22:39:38 UTC) #2
Alpha Left Google
https://codereview.chromium.org/901833004/diff/20001/chrome/renderer/media/cast_session_delegate.cc File chrome/renderer/media/cast_session_delegate.cc (right): https://codereview.chromium.org/901833004/diff/20001/chrome/renderer/media/cast_session_delegate.cc#newcode240 chrome/renderer/media/cast_session_delegate.cc:240: break; Can we log this or there's already a ...
5 years, 10 months ago (2015-02-07 01:18:58 UTC) #3
Alpha Left Google
5 years, 10 months ago (2015-02-07 01:18:58 UTC) #4
miu
https://codereview.chromium.org/901833004/diff/20001/chrome/renderer/media/cast_session_delegate.cc File chrome/renderer/media/cast_session_delegate.cc (right): https://codereview.chromium.org/901833004/diff/20001/chrome/renderer/media/cast_session_delegate.cc#newcode240 chrome/renderer/media/cast_session_delegate.cc:240: break; On 2015/02/07 01:18:57, Alpha wrote: > Can we ...
5 years, 10 months ago (2015-02-07 01:37:02 UTC) #5
Alpha Left Google
Okay. LGTM.
5 years, 10 months ago (2015-02-07 02:36:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901833004/20001
5 years, 10 months ago (2015-02-07 05:21:29 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-07 05:25:39 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 05:27:00 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6377eb4a7055d3135e286e71b563ccd100ed4669
Cr-Commit-Position: refs/heads/master@{#315187}

Powered by Google App Engine
This is Rietveld 408576698