Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 901833002: Allow MimeHandlerViewGuest to be notified of StopFinding events. (Closed)

Created:
5 years, 10 months ago by raymes
Modified:
5 years, 10 months ago
Reviewers:
Fady Samuel, Yoyo Zhou, jam
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow MimeHandlerViewGuest to be notified of StopFinding events. Currently we notify the guest of StartFind events but not StopFinding. BUG=455079 Committed: https://crrev.com/2bc641826d5be9a0f59b0a0fb9948efbab69c2b2 Cr-Commit-Position: refs/heads/master@{#314939}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -8 lines) Patch
M content/browser/browser_plugin/browser_plugin_embedder.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_embedder.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/browser/browser_plugin_guest_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/browser_plugin_guest_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/api/web_view/web_view_internal_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.h View 1 chunk +5 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
raymes
5 years, 10 months ago (2015-02-05 06:54:55 UTC) #2
Fady Samuel
lgtm, note the embedded case will be broken though.
5 years, 10 months ago (2015-02-05 12:06:51 UTC) #3
raymes
On 2015/02/05 12:06:51, Fady Samuel wrote: > lgtm, note the embedded case will be broken ...
5 years, 10 months ago (2015-02-05 22:41:49 UTC) #4
raymes
+OWNERS jam for: content/browser/web_contents/web_contents_impl.cc content/public/browser/browser_plugin_guest_delegate.h content/public/browser/browser_plugin_guest_delegate.cc yoz for: extensions/browser/api/web_view/web_view_internal_api.cc
5 years, 10 months ago (2015-02-05 22:44:23 UTC) #6
raymes
+OWNERS jam for: content/browser/web_contents/web_contents_impl.cc content/public/browser/browser_plugin_guest_delegate.h content/public/browser/browser_plugin_guest_delegate.cc yoz for: extensions/browser/api/web_view/web_view_internal_api.cc
5 years, 10 months ago (2015-02-05 22:44:39 UTC) #8
Yoyo Zhou
web_view_internal_api lgtm
5 years, 10 months ago (2015-02-05 22:47:37 UTC) #9
jam
lgtm
5 years, 10 months ago (2015-02-05 23:03:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901833002/20001
5 years, 10 months ago (2015-02-05 23:51:03 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-06 01:23:42 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 01:24:28 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2bc641826d5be9a0f59b0a0fb9948efbab69c2b2
Cr-Commit-Position: refs/heads/master@{#314939}

Powered by Google App Engine
This is Rietveld 408576698