Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 9018024: Remove references to obsolete TOUCH_UI build - extension sample (Closed)

Created:
9 years ago by Rick Byers
Modified:
9 years ago
Reviewers:
jstritar
CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Remove references to obsolete TOUCH_UI build - extension sample This sample includes a copy of the WebUI cr.js. We've removed all references to the old TOUCH_UI build from most of the code (including the main copy of cr.js). This updates the copy here and rebuilds the extension docs as requested by presubmit. Note that rebuilding the extension docs also gave me some unrelated changes to window.html (presumably because someone else failed to rebuild after updating) - I have not included those unrelated changes here. BUG=105046 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115554

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/common/extensions/docs/examples/extensions/plugin_settings.zip View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/plugin_settings/domui/js/cr.js View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Rick Byers
Hi Jon, Can you please review this tiny tweak to one of the extension samples. ...
9 years ago (2011-12-21 20:01:13 UTC) #1
jstritar
LGTM thanks for the cleanup.
9 years ago (2011-12-22 15:16:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/9018024/1
9 years ago (2011-12-22 15:24:14 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-22 18:07:59 UTC) #4
Change committed as 115554

Powered by Google App Engine
This is Rietveld 408576698