Issue 9018002: Refactor some of the snapshot writer classes to eliminate code duplication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9018002: Refactor some of the snapshot writer classes to eliminate code duplication. (Closed)

Created:
9 years ago by siva

Modified:
9 years ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Refactor some of the snapshot writer classes to eliminate code duplication. Committed: https://code.google.com/p/dart/source/detail?r=2718

Patch Set 3 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -55 lines)			Patch
	M	vm/dart_api_impl.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
	M	vm/snapshot.h	View	1 2	3 chunks	+35 lines, -53 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM, feel free to ignore comment. http://codereview.chromium.org/9018002/diff/2001/vm/snapshot.h File vm/snapshot.h (right): http://codereview.chromium.org/9018002/diff/2001/vm/snapshot.h#newcode336 vm/snapshot.h:336: intptr_t Size() const ...

9 years ago (2011-12-21 17:15:38 UTC) #2

siva

9 years ago (2011-12-21 19:22:08 UTC) #3

http://codereview.chromium.org/9018002/diff/2001/vm/snapshot.h
File vm/snapshot.h (right):

http://codereview.chromium.org/9018002/diff/2001/vm/snapshot.h#newcode336
vm/snapshot.h:336: intptr_t Size() const { return stream_.bytes_written(); }
Renamed to BytesWritten.

On 2011/12/21 17:15:39, hausner wrote:
> You didn't introduce this name in this change, but I find Size() a bit
> misleading because it's only valid after the data has been written.

Expand Messages | Collapse Messages

Issue 9018002: Refactor some of the snapshot writer classes to eliminate code duplication. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages