net/udp/udp_socket_win.cc - Issue 901773002: Adding instrumentation to locate the source of jankiness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/udp/udp_socket_win.cc

Issue 901773002: Adding instrumentation to locate the source of jankiness. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/udp/udp_socket_win.cc

diff --git a/net/udp/udp_socket_win.cc b/net/udp/udp_socket_win.cc

index 3c121b2bd91a6beabbb86f6e6764eee11f06135c..9f463818c7ed3c7c25ecc138b0f1b85dfccfc1c1 100644

--- a/net/udp/udp_socket_win.cc

+++ b/net/udp/udp_socket_win.cc

@@ -149,7 +149,7 @@ void UDPSocketWin::Core::ReadDelegate::OnObjectSignaled(HANDLE object) {

// TODO(vadimt): Remove ScopedTracker below once crbug.com/418183 is fixed.

tracked_objects::ScopedTracker tracking_profile(

FROM_HERE_WITH_EXPLICIT_FUNCTION(

- "UDPSocketWin_Core_ReadDelegate_OnObjectSignaled"));

+ "418183 UDPSocketWin::Core::ReadDelegate::OnObjectSignaled"));

DCHECK_EQ(object, core_->read_overlapped_.hEvent);

if (core_->socket_)

@@ -162,7 +162,7 @@ void UDPSocketWin::Core::WriteDelegate::OnObjectSignaled(HANDLE object) {

// TODO(vadimt): Remove ScopedTracker below once crbug.com/418183 is fixed.

tracked_objects::ScopedTracker tracking_profile(

FROM_HERE_WITH_EXPLICIT_FUNCTION(

- "UDPSocketWin_Core_WriteDelegate_OnObjectSignaled"));

+ "418183 UDPSocketWin::Core::WriteDelegate::OnObjectSignaled"));

DCHECK_EQ(object, core_->write_overlapped_.hEvent);

if (core_->socket_)

« net/socket/tcp_socket_win.cc ('K') | « net/socket/tcp_socket_win.cc ('k') | net/url_request/url_request_job.cc » ('j') | no next file with comments »