Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 901753002: Cleaning up some tests (Closed)

Created:
5 years, 10 months ago by Charlie
Modified:
5 years, 10 months ago
Reviewers:
rkc
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This removes some unused code and simplifies some dependencies. I'm planning to pull the audio code out into its own component, and it'll be clearer if I do minimal refactoring along the way. Committed: https://crrev.com/88444c0bae2e77ab555a81a727d5ffa49500adf2 Cr-Commit-Position: refs/heads/master@{#314733}

Patch Set 1 #

Patch Set 2 : Fixing lint errors #

Patch Set 3 : Using rand() instead of rand_r() on Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -39 lines) Patch
M components/copresence/mediums/audio/audio_manager_unittest.cc View 1 2 chunks +10 lines, -2 lines 0 comments Download
M components/copresence/test/audio_test_support.h View 1 2 chunks +3 lines, -8 lines 0 comments Download
M components/copresence/test/audio_test_support.cc View 1 2 1 chunk +6 lines, -9 lines 0 comments Download
M components/copresence/test/stub_whispernet_client.h View 2 chunks +10 lines, -5 lines 0 comments Download
M components/copresence/test/stub_whispernet_client.cc View 1 chunk +7 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Charlie
5 years, 10 months ago (2015-02-05 00:11:06 UTC) #2
rkc
lgtm
5 years, 10 months ago (2015-02-05 00:18:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901753002/20001
5 years, 10 months ago (2015-02-05 01:28:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/23157)
5 years, 10 months ago (2015-02-05 01:55:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901753002/40001
5 years, 10 months ago (2015-02-05 02:56:51 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-05 03:27:29 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 03:28:20 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/88444c0bae2e77ab555a81a727d5ffa49500adf2
Cr-Commit-Position: refs/heads/master@{#314733}

Powered by Google App Engine
This is Rietveld 408576698