Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 901733002: Pepper: Make C++ pp::VideoEncoder wrapper compilable on non-C++11 builds. (Closed)

Created:
5 years, 10 months ago by bbudge
Modified:
5 years, 10 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, bradnelson+warch_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pepper: Make C++ pp::VideoEncoder wrapper compilable on non-C++11 builds. BUG=455409 Committed: https://crrev.com/5b6f40c8c46d3bc9c9c77b58d5bdbb8d3c098329 Cr-Commit-Position: refs/heads/master@{#314696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ppapi/cpp/video_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/cpp/video_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
bbudge
Broke the nacl_sdk build.
5 years, 10 months ago (2015-02-04 23:08:21 UTC) #2
bbudge
5 years, 10 months ago (2015-02-04 23:08:53 UTC) #3
Sam Clegg
lgtm (although I dont think I'm an not OWNER of ppapi)
5 years, 10 months ago (2015-02-04 23:10:17 UTC) #5
dmichael (off chromium)
lgtm
5 years, 10 months ago (2015-02-04 23:19:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901733002/1
5 years, 10 months ago (2015-02-04 23:20:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 00:56:41 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 00:59:23 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5b6f40c8c46d3bc9c9c77b58d5bdbb8d3c098329
Cr-Commit-Position: refs/heads/master@{#314696}

Powered by Google App Engine
This is Rietveld 408576698