Pepper: Fix VideoDecoderShim texture upload.

Pepper: Fix VideoDecoderShim texture upload.
VideoFrame conversion is to RGBA, so we need to specify
BGRA when uploading the texture.

BUG=450205
Committed: https://crrev.com/8cff53a68bdd2b1e0e816c51cc68b6a5fd1b92c2
Cr-Commit-Position: refs/heads/master@{#315141}

[bbudge, 2015-02-06 02:56:23]

bbudge@chromium.org changed reviewers:
+ sandersd@chromium.org

[bbudge, 2015-02-06 02:56:23]

This seems to fix the problem, but I'm wondering if it's correct.

[sandersd (OOO until July 31), 2015-02-06 21:19:34]

I went through the libyuv code, and found the source of my confusion. The names
of the methods are reversed compared to the in-memory layout; so the actual
memory layouts are:

  - Android: RGBA
  - Everything else: BGRA

This means that on Android you should use GL_RGBA, and everywhere else this CL
is correct.

For now I would say that the best plan is to fail to compile for Android, since
there are currently no codecs there to use through this API anyway.


lgtm

[bbudge, 2015-02-06 21:41:43]

New patchsets have been uploaded after l-g-t-m from sandersd@chromium.org

[bbudge, 2015-02-06 21:50:50]

On 2015/02/06 21:19:34, sandersd wrote:
> I went through the libyuv code, and found the source of my confusion. The
names
> of the methods are reversed compared to the in-memory layout; so the actual
> memory layouts are:
> 
>   - Android: RGBA
>   - Everything else: BGRA
> 
> This means that on Android you should use GL_RGBA, and everywhere else this CL
> is correct.
> 
> For now I would say that the best plan is to fail to compile for Android,
since
> there are currently no codecs there to use through this API anyway.
> 
> 
> lgtm

Agreed. It's unclear how this would work if / when Pepper is available on
Android.

[bbudge, 2015-02-06 21:50:59]

The CQ bit was checked by bbudge@chromium.org

[commit-bot: I haz the power, 2015-02-06 21:52:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/901683004/60001

[commit-bot: I haz the power, 2015-02-06 23:55:45]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-06 23:56:10]

Patchset 4 (id:??) landed as
https://crrev.com/8cff53a68bdd2b1e0e816c51cc68b6a5fd1b92c2
Cr-Commit-Position: refs/heads/master@{#315141}