Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: Source/platform/LifecycleNotifier.h

Issue 901663005: Revert r189385 "Remove LifecycleContext" and r189391, r189530, r189456 that block it (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/LifecycleContextTest.cpp ('k') | Source/platform/LifecycleObserver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/LifecycleNotifier.h
diff --git a/Source/platform/LifecycleNotifier.h b/Source/platform/LifecycleNotifier.h
index 3aff06828977bcf97d6360fc09516ac66f202a74..234b320f00b476508ab44065e795361aa9ea8554 100644
--- a/Source/platform/LifecycleNotifier.h
+++ b/Source/platform/LifecycleNotifier.h
@@ -40,8 +40,12 @@ public:
typedef LifecycleObserver<T> Observer;
typedef T Context;
+ static PassOwnPtr<LifecycleNotifier> create(Context* context)
+ {
+ return adoptPtr(new LifecycleNotifier(context));
+ }
+
virtual ~LifecycleNotifier();
- virtual bool isContextThread() const { return true; }
// notifyContextDestroyed() should be explicitly dispatched from an
// observed context to notify observers contextDestroyed().
@@ -53,7 +57,7 @@ public:
virtual void addObserver(Observer*);
virtual void removeObserver(Observer*);
- virtual void trace(Visitor*) { }
+ bool isIteratingOverObservers() const { return m_iterating != IteratingNone; }
protected:
explicit LifecycleNotifier(Context* context)
@@ -91,7 +95,7 @@ inline LifecycleNotifier<T>::~LifecycleNotifier()
// ASSERT(!m_observers.size() || m_didCallContextDestroyed);
#if !ENABLE(OILPAN)
- TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll);
+ TemporaryChange<IterationType> scope(this->m_iterating, IteratingOverAll);
for (Observer* observer : m_observers) {
ASSERT(observer->lifecycleContext() == m_context);
observer->clearLifecycleContext();
@@ -106,7 +110,7 @@ inline void LifecycleNotifier<T>::notifyContextDestroyed()
if (m_didCallContextDestroyed)
return;
- TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll);
+ TemporaryChange<IterationType> scope(this->m_iterating, IteratingOverAll);
Vector<Observer*> snapshotOfObservers;
copyToVector(m_observers, snapshotOfObservers);
for (Observer* observer : snapshotOfObservers) {
« no previous file with comments | « Source/platform/LifecycleContextTest.cpp ('k') | Source/platform/LifecycleObserver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698