Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: Source/platform/LifecycleContextTest.cpp

Issue 901663005: Revert r189385 "Remove LifecycleContext" and r189391, r189530, r189456 that block it (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/LifecycleContext.h ('k') | Source/platform/LifecycleNotifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/LifecycleContextTest.cpp
diff --git a/Source/platform/LifecycleContextTest.cpp b/Source/platform/LifecycleContextTest.cpp
index 09ba564d17fbd49f6c99fdc839d0ae189481e727..883766a7d17ce8bddf9ab298759c63e836385623 100644
--- a/Source/platform/LifecycleContextTest.cpp
+++ b/Source/platform/LifecycleContextTest.cpp
@@ -26,6 +26,8 @@
#include "config.h"
+#include "platform/LifecycleContext.h"
+
#include "platform/LifecycleNotifier.h"
#include "platform/heap/Handle.h"
#include <gtest/gtest.h>
@@ -34,27 +36,29 @@ using namespace blink;
namespace blink {
-class DummyContext final : public NoBaseWillBeGarbageCollectedFinalized<DummyContext>, public LifecycleNotifier<DummyContext> {
+class DummyContext final : public NoBaseWillBeGarbageCollectedFinalized<DummyContext>, public LifecycleContext<DummyContext> {
public:
- DummyContext()
- : LifecycleNotifier<DummyContext>(this)
+ PassOwnPtr<LifecycleNotifier<DummyContext>> createLifecycleNotifier()
{
+ return LifecycleNotifier<DummyContext>::create(this);
}
-
- void trace(Visitor* visitor)
+ LifecycleNotifier<DummyContext>& lifecycleNotifier()
{
- LifecycleNotifier<DummyContext>::trace(visitor);
+ return static_cast<LifecycleNotifier<DummyContext>&>(LifecycleContext<DummyContext>::lifecycleNotifier());
}
+
+private:
+ OwnPtr<LifecycleNotifier<DummyContext>> m_lifecycleNotifier;
};
-template<> void observeContext(DummyContext* context, LifecycleObserver<DummyContext>* observer)
+template<> void observerContext(DummyContext* context, LifecycleObserver<DummyContext>* observer)
{
- context->addObserver(observer);
+ context->wasObservedBy(observer);
}
-template<> void unobserveContext(DummyContext* context, LifecycleObserver<DummyContext>* observer)
+template<> void unobserverContext(DummyContext* context, LifecycleObserver<DummyContext>* observer)
{
- context->removeObserver(observer);
+ context->wasUnobservedBy(observer);
}
class TestingObserver final : public GarbageCollectedFinalized<TestingObserver>, public LifecycleObserver<DummyContext> {
@@ -78,7 +82,7 @@ public:
bool m_contextDestroyedCalled;
- void unobserve() { setContext(nullptr); }
+ void unobserve() { observeContext(0); }
};
TEST(LifecycleContextTest, shouldObserveContextDestroyed)
« no previous file with comments | « Source/platform/LifecycleContext.h ('k') | Source/platform/LifecycleNotifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698