Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: Source/core/frame/DOMWindowLifecycleNotifier.h

Issue 901663005: Revert r189385 "Remove LifecycleContext" and r189391, r189530, r189456 that block it (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/DOMWindowLifecycleNotifier.h
diff --git a/Source/core/frame/DOMWindowLifecycleNotifier.h b/Source/core/frame/DOMWindowLifecycleNotifier.h
index 0dd1f6f3609a0b688c84011d74e78c357faea407..82ec68dfeb108959a3b1e4b7047a99c97d64391e 100644
--- a/Source/core/frame/DOMWindowLifecycleNotifier.h
+++ b/Source/core/frame/DOMWindowLifecycleNotifier.h
@@ -26,19 +26,19 @@
#ifndef DOMWindowLifecycleNotifier_h
#define DOMWindowLifecycleNotifier_h
+#include "core/frame/DOMWindowLifecycleObserver.h"
+#include "core/frame/LocalDOMWindow.h"
#include "platform/LifecycleNotifier.h"
-#include "wtf/HashSet.h"
#include "wtf/PassOwnPtr.h"
#include "wtf/TemporaryChange.h"
#include "wtf/text/WTFString.h"
namespace blink {
-class DOMWindowLifecycleObserver;
-class LocalDOMWindow;
-
-class DOMWindowLifecycleNotifier : public LifecycleNotifier<LocalDOMWindow> {
+class DOMWindowLifecycleNotifier final : public LifecycleNotifier<LocalDOMWindow> {
public:
+ static PassOwnPtr<DOMWindowLifecycleNotifier> create(LocalDOMWindow*);
+
void notifyAddEventListener(LocalDOMWindow*, const AtomicString& eventType);
void notifyRemoveEventListener(LocalDOMWindow*, const AtomicString& eventType);
void notifyRemoveAllEventListeners(LocalDOMWindow*);
@@ -46,10 +46,9 @@ public:
virtual void addObserver(Observer*) override;
virtual void removeObserver(Observer*) override;
-protected:
+private:
explicit DOMWindowLifecycleNotifier(LocalDOMWindow*);
-private:
typedef HashSet<DOMWindowLifecycleObserver*> DOMWindowObserverSet;
DOMWindowObserverSet m_windowObservers;
};
« no previous file with comments | « Source/core/dom/ScopedWindowFocusAllowedIndicator.h ('k') | Source/core/frame/DOMWindowLifecycleNotifier.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698