Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: Source/core/frame/DOMWindowLifecycleNotifier.cpp

Issue 901663005: Revert r189385 "Remove LifecycleContext" and r189391, r189530, r189456 that block it (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/DOMWindowLifecycleNotifier.h ('k') | Source/core/frame/DOMWindowLifecycleObserver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/DOMWindowLifecycleNotifier.cpp
diff --git a/Source/core/frame/DOMWindowLifecycleNotifier.cpp b/Source/core/frame/DOMWindowLifecycleNotifier.cpp
index a081e45e488cb717d032966d5f7e33b3caa018f8..6d5549356f8e1a7b743d8e7b988eb5be16d6acd0 100644
--- a/Source/core/frame/DOMWindowLifecycleNotifier.cpp
+++ b/Source/core/frame/DOMWindowLifecycleNotifier.cpp
@@ -27,8 +27,6 @@
#include "config.h"
#include "core/frame/DOMWindowLifecycleNotifier.h"
-#include "core/frame/DOMWindowLifecycleObserver.h"
-
namespace blink {
DOMWindowLifecycleNotifier::DOMWindowLifecycleNotifier(LocalDOMWindow* context)
@@ -56,23 +54,28 @@ void DOMWindowLifecycleNotifier::removeObserver(DOMWindowLifecycleNotifier::Obse
LifecycleNotifier<LocalDOMWindow>::removeObserver(observer);
}
+PassOwnPtr<DOMWindowLifecycleNotifier> DOMWindowLifecycleNotifier::create(LocalDOMWindow* context)
+{
+ return adoptPtr(new DOMWindowLifecycleNotifier(context));
+}
+
void DOMWindowLifecycleNotifier::notifyAddEventListener(LocalDOMWindow* window, const AtomicString& eventType)
{
- TemporaryChange<IterationType> scope(m_iterating, IteratingOverDOMWindowObservers);
+ TemporaryChange<IterationType> scope(this->m_iterating, IteratingOverDOMWindowObservers);
for (const auto& windowObserver : m_windowObservers)
windowObserver->didAddEventListener(window, eventType);
}
void DOMWindowLifecycleNotifier::notifyRemoveEventListener(LocalDOMWindow* window, const AtomicString& eventType)
{
- TemporaryChange<IterationType> scope(m_iterating, IteratingOverDOMWindowObservers);
+ TemporaryChange<IterationType> scope(this->m_iterating, IteratingOverDOMWindowObservers);
for (const auto& windowObserver : m_windowObservers)
windowObserver->didRemoveEventListener(window, eventType);
}
void DOMWindowLifecycleNotifier::notifyRemoveAllEventListeners(LocalDOMWindow* window)
{
- TemporaryChange<IterationType> scope(m_iterating, IteratingOverDOMWindowObservers);
+ TemporaryChange<IterationType> scope(this->m_iterating, IteratingOverDOMWindowObservers);
for (const auto& windowObserver : m_windowObservers)
windowObserver->didRemoveAllEventListeners(window);
}
« no previous file with comments | « Source/core/frame/DOMWindowLifecycleNotifier.h ('k') | Source/core/frame/DOMWindowLifecycleObserver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698